content/browser/service_worker/service_worker_version.h - Issue 980383004: Relax same-origin policy for ServiceWorker openWindow() in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 980383004: Relax same-origin policy for ServiceWorker openWindow() in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 4d327701ae5524bb74d48b12facdf75969eb16a7..954aecc707989a139ec53d04a3f6f5b2dd33105a 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -360,7 +360,7 @@ class CONTENT_EXPORT ServiceWorkerVersion

void OnGeofencingEventFinished(int request_id);

void OnCrossOriginConnectEventFinished(int request_id,

bool accept_connection);

- void OnOpenWindow(int request_id, const GURL& url);

+ void OnOpenWindow(int request_id, GURL url);

void DidOpenWindow(int request_id,

int render_process_id,

int render_frame_id);

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »