Adding expand / secondary decode rate to WebRTC regression monitoring.

Adding expand / secondary decode rate to WebRTC regression monitoring.

BUG=464277
Committed: https://crrev.com/c97215297520206ce229363f2736fff4de5918fc
Cr-Commit-Position: refs/heads/master@{#319627}

[phoglund_chromium, 2015-03-05 16:57:21]

phoglund@chromium.org changed reviewers:
+ minyue@chromium.org

[phoglund_chromium, 2015-03-09 10:00:26]

ping

[chromium-reviews, 2015-03-09 11:53:42]

Thank you for reminder.

I did not pay much attention to this, since I do not receive many chromium
reviews. My apologies.

On Mon, Mar 9, 2015 at 11:00 AM, <phoglund@chromium.org> wrote:

> ping
>
> https://codereview.chromium.org/980373002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[minyue, 2015-03-09 11:56:01]

https://codereview.chromium.org/980373002/diff/1/chrome/browser/media/webrtc_...
File chrome/browser/media/webrtc_browsertest_perf.cc (right):

https://codereview.chromium.org/980373002/diff/1/chrome/browser/media/webrtc_...
chrome/browser/media/webrtc_browsertest_perf.cc:39:
EXPECT_TRUE(pc_dict.GetString(Statistic("googExpandRate", ssrc), &value));
googSpeechExpandRate and googSecondaryDecodedRate are new

wasn't even googExpandRate used before?

[phoglund_chromium, 2015-03-09 12:05:12]

PTAL

https://codereview.chromium.org/980373002/diff/1/chrome/browser/media/webrtc_...
File chrome/browser/media/webrtc_browsertest_perf.cc (right):

https://codereview.chromium.org/980373002/diff/1/chrome/browser/media/webrtc_...
chrome/browser/media/webrtc_browsertest_perf.cc:39:
EXPECT_TRUE(pc_dict.GetString(Statistic("googExpandRate", ssrc), &value));
On 2015/03/09 11:56:01, minyue wrote:
> googSpeechExpandRate and googSecondaryDecodedRate are new
> 
> wasn't even googExpandRate used before?

Nope, apparently not. I made this test a while back and it probably didn't exist
by then.

[minyue, 2015-03-09 12:09:24]

Thanks for doing this!

LGTM

[phoglund_chromium, 2015-03-09 12:32:02]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2015-03-09 12:32:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/980373002/1

[commit-bot: I haz the power, 2015-03-09 12:32:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 12:32:12]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[phoglund_chromium, 2015-03-09 13:01:15]

phoglund@chromium.org changed reviewers:
+ kjellander@chromium.org

[phoglund_chromium, 2015-03-09 13:01:15]

Henrik: need committer lgtm as well

[kjellander_chromium, 2015-03-09 13:15:11]

lgtm

[phoglund_chromium, 2015-03-09 13:25:49]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2015-03-09 13:26:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/980373002/1

[commit-bot: I haz the power, 2015-03-09 14:15:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-09 14:17:07]

Patchset 1 (id:??) landed as
https://crrev.com/c97215297520206ce229363f2736fff4de5918fc
Cr-Commit-Position: refs/heads/master@{#319627}