Extensions: Switch to new permission message system, part I

extensions/common/permissions/permissions_data.h

Index: extensions/common/permissions/permissions_data.h
diff --git a/extensions/common/permissions/permissions_data.h b/extensions/common/permissions/permissions_data.h
index 9a24fbf05d28d6288902bf7d2eb0dd686d5962a4..88d716cdaaff71e1b0ca10d69b64357633825281 100644
--- a/extensions/common/permissions/permissions_data.h
+++ b/extensions/common/permissions/permissions_data.h
@@ -71,7 +71,7 @@ class PermissionsData {
       const Extension* extension,
       const PermissionSet* permissions);
 
-  // Returns true if we should skip the permisisons warning for the extension
+  // Returns true if we should skip the permissions warning for the extension
   // with the given |extension_id|.
   static bool ShouldSkipPermissionWarnings(const std::string& extension_id);
 
@@ -133,18 +133,21 @@ class PermissionsData {
 
   // Returns the full list of permission messages that should display at
   // install time.
-  // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().
-  PermissionMessages GetPermissionMessages() const;
+  // Deprecated; use GetCoalescedPermissionMessages() instead.

[Yoyo Zhou, 2015/03/17 00:02:05]

Why was this removed? I think it helps to say what to use instead.

[Marc Treib, 2015/03/17 10:00:27]

Ah, the CL's confusing here, sorry about that.
The existing GetPermissionMessageStrings was renamed to
GetLegacyPermissionMessageStrings, and that one still has the deprecation
comment.
This new GetPermissionMessageStrings is the new interim API which calls either
the old or the new system, so this is what's actually supposed to be used. (My
next CL will switch all callers of the Legacy methods over to this one.)

I've updated the deprecation comments on the other methods to refer to this
method as the one to be used.

+  // TODO(treib): Remove this once we've fully switched to the new system.
+  PermissionMessages GetLegacyPermissionMessages() const;
 
   // Returns the full list of permission messages that should display at install
   // time as strings.
-  // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().
-  std::vector<base::string16> GetPermissionMessageStrings() const;
+  // Deprecated; use GetCoalescedPermissionMessages() instead.
+  // TODO(treib): Remove this once we've fully switched to the new system.
+  std::vector<base::string16> GetLegacyPermissionMessageStrings() const;
 
   // Returns the full list of permission details for messages that should
   // display at install time as strings.
-  // TODO(sashab): Deprecate this in favor of GetCoalescedPermissionMessages().
-  std::vector<base::string16> GetPermissionMessageDetailsStrings() const;
+  // Deprecated; use GetCoalescedPermissionMessages() instead.
+  // TODO(treib): Remove this once we've fully switched to the new system.
+  std::vector<base::string16> GetLegacyPermissionMessageDetailsStrings() const;
 
   // Returns the full list of permission details for messages that should
   // display at install time, in a nested format ready for display.