chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc - Issue 980353003: Extensions: Switch to new permission message system, part I

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

Issue 980353003: Extensions: Switch to new permission message system, part I (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/permission_message_combinations_unittest.cc ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

index 95df36ec36109977da507d60dd1d45b79a83302c..5d2b60da33c787f34944c51b0da49e10b9956827 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

@@ -263,9 +263,9 @@ const std::vector<PermissionStringAndDetailsPair>

AppInfoPermissionsPanel::GetActivePermissionMessages() const {

std::vector<PermissionStringAndDetailsPair> messages_with_details;

std::vector<base::string16> permission_messages =

- app_->permissions_data()->GetPermissionMessageStrings();

+ app_->permissions_data()->GetLegacyPermissionMessageStrings();

std::vector<base::string16> permission_message_details =

- app_->permissions_data()->GetPermissionMessageDetailsStrings();

+ app_->permissions_data()->GetLegacyPermissionMessageDetailsStrings();

DCHECK_EQ(permission_messages.size(), permission_message_details.size());

for (size_t i = 0; i < permission_messages.size(); i++) {