extensions/shell/common/shell_extensions_client.cc - Issue 980353003: Extensions: Switch to new permission message system, part I

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/common/shell_extensions_client.cc

Issue 980353003: Extensions: Switch to new permission message system, part I (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/permissions/permission_message_test_util.cc ('K') | « extensions/extensions.gypi ('k') | extensions/test/test_permission_message_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/common/shell_extensions_client.cc

diff --git a/extensions/shell/common/shell_extensions_client.cc b/extensions/shell/common/shell_extensions_client.cc

index 072ebb1cdf218ec243c7cf3f5ee4e41671f165b1..c3d07ea45460c938433b601f487efc99fd8409f1 100644

--- a/extensions/shell/common/shell_extensions_client.cc

+++ b/extensions/shell/common/shell_extensions_client.cc

@@ -42,12 +42,6 @@ class ShellPermissionMessageProvider : public PermissionMessageProvider {

~ShellPermissionMessageProvider() override {}

// PermissionMessageProvider implementation.

- PermissionMessageStrings GetPermissionMessageStrings(

- const PermissionSet* permissions,

- Manifest::Type extension_type) const override {

- return PermissionMessageStrings();

- }

PermissionMessageIDs GetLegacyPermissionMessageIDs(

const PermissionSet* permissions,

Manifest::Type extension_type) const override {