Extensions: Switch to new permission message system, part I

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <iterator>
 #include <set>
 
@@ skipping 1000 matching lines @@
   // Since this is called from multiple sources, and since the histogram macros
   // use statics, we need to manually lookup the histogram ourselves.
   base::HistogramBase* counter = base::LinearHistogram::FactoryGet(
       histogram,
       1,
       PermissionMessage::kEnumBoundary,
       PermissionMessage::kEnumBoundary + 1,
       base::HistogramBase::kUmaTargetedHistogramFlag);
 
   PermissionMessages permissions =
-      extension->permissions_data()->GetPermissionMessages();
+      extension->permissions_data()->GetLegacyPermissionMessages();

[Marc Treib, 2015/03/09 14:08:02]

Unfortunately, we can't just switch to the new system here, since the old IDs
are used in a histogram. We'll have to break that if we want to actually remove
the old stuff :-(

[Yoyo Zhou, 2015/03/11 01:33:23]

Can we introduce a new histogram? I imagine we are still interested in
collecting this data, but if we're measuring something different, we need a new
histogram. Of course, I don't think we want to deprecate the old one before the
new one is ready.

[Marc Treib, 2015/03/11 13:08:52]

Yes, I think we'll introduce a new histogram to (eventually) replace this one.
I'd like to add the new histogram in a separate CL though; this one is already
way too large.

   if (permissions.empty()) {
     counter->Add(PermissionMessage::kNone);
   } else {
     for (PermissionMessages::iterator it = permissions.begin();
          it != permissions.end(); ++it)
       counter->Add(it->id());
   }
 }
 
 void ExtensionService::NotifyExtensionLoaded(const Extension* extension) {
@@ skipping 1550 matching lines @@
 }
 
 void ExtensionService::OnProfileDestructionStarted() {
   ExtensionIdSet ids_to_unload = registry_->enabled_extensions().GetIDs();
   for (ExtensionIdSet::iterator it = ids_to_unload.begin();
        it != ids_to_unload.end();
        ++it) {
     UnloadExtension(*it, UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN);
   }
 }