Extensions: Switch to new permission message system, part I

chrome/common/extensions/permissions/permissions_data_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/extensions/extension_test_util.h"
 #include "components/crx_file/id_util.h"
 #include "content/public/common/socket_permission_request.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/permissions/api_permission.h"
+#include "extensions/common/permissions/permission_message_test_util.h"
 #include "extensions/common/permissions/permission_set.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "extensions/common/permissions/socket_permission.h"
 #include "extensions/common/switches.h"
 #include "extensions/common/url_pattern_set.h"
 #include "extensions/common/value_builder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 
 using base::UTF16ToUTF8;
@@ skipping 255 matching lines @@
 
   base::CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kExtensionsOnChromeURLs);
   // Enabling the switch should allow all extensions to access chrome urls.
   CheckRestrictedUrls(extension.get(), false);
 }
 
 TEST(PermissionsDataTest, GetPermissionMessages_ManyAPIPermissions) {
   scoped_refptr<Extension> extension;
   extension = LoadManifest("permissions", "many-apis.json");
-  std::vector<base::string16> warnings =
-      extension->permissions_data()->GetPermissionMessageStrings();
   // Warning for "tabs" is suppressed by "history" permission.
-  ASSERT_EQ(5u, warnings.size());
-  EXPECT_EQ("Read and change your data on api.flickr.com",
-            UTF16ToUTF8(warnings[0]));
-  EXPECT_EQ("Read and change your bookmarks", UTF16ToUTF8(warnings[1]));
-  EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2]));
-  EXPECT_EQ("Read and change your browsing history", UTF16ToUTF8(warnings[3]));
-  EXPECT_EQ("Manage your apps, extensions, and themes",
-            UTF16ToUTF8(warnings[4]));
+  std::vector<std::string> expected_messages;
+  expected_messages.push_back("Read and change your data on api.flickr.com");
+  expected_messages.push_back("Read and change your bookmarks");
+  expected_messages.push_back("Detect your physical location");
+  expected_messages.push_back("Read and change your browsing history");
+  expected_messages.push_back("Manage your apps, extensions, and themes");
+  EXPECT_TRUE(VerifyPermissionMessages(extension->permissions_data(),
+                                       expected_messages, false));
 }
 
 TEST(PermissionsDataTest, GetPermissionMessages_ManyHostsPermissions) {
   scoped_refptr<Extension> extension;
   extension = LoadManifest("permissions", "more-than-3-hosts.json");
-  std::vector<base::string16> warnings =
-      extension->permissions_data()->GetPermissionMessageStrings();
-  std::vector<base::string16> warnings_details =
-      extension->permissions_data()->GetPermissionMessageDetailsStrings();
-  ASSERT_EQ(1u, warnings.size());
-  ASSERT_EQ(1u, warnings_details.size());
-  EXPECT_EQ("Read and change your data on a number of websites",
-            UTF16ToUTF8(warnings[0]));
-  EXPECT_EQ("www.a.com\nwww.b.com\nwww.c.com\nwww.d.com\nwww.e.com",
-            UTF16ToUTF8(warnings_details[0]));
+  std::vector<std::string> submessages;
+  submessages.push_back("www.a.com");
+  submessages.push_back("www.b.com");
+  submessages.push_back("www.c.com");
+  submessages.push_back("www.d.com");
+  submessages.push_back("www.e.com");
+  EXPECT_TRUE(VerifyOnePermissionMessageWithSubmessages(
+      extension->permissions_data(),
+      "Read and change your data on a number of websites", submessages));
 }
 
 TEST(PermissionsDataTest, GetPermissionMessages_LocationApiPermission) {
   scoped_refptr<Extension> extension;
   extension = LoadManifest("permissions",
                            "location-api.json",
                            Manifest::COMPONENT,
                            Extension::NO_FLAGS);
-  std::vector<base::string16> warnings =
-      extension->permissions_data()->GetPermissionMessageStrings();
-  ASSERT_EQ(1u, warnings.size());
-  EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[0]));
+  EXPECT_TRUE(VerifyOnePermissionMessage(extension->permissions_data(),
+                                         "Detect your physical location"));
 }
 
 TEST(PermissionsDataTest, GetPermissionMessages_ManyHosts) {
   scoped_refptr<Extension> extension;
   extension = LoadManifest("permissions", "many-hosts.json");
-  std::vector<base::string16> warnings =
-      extension->permissions_data()->GetPermissionMessageStrings();
-  ASSERT_EQ(1u, warnings.size());
-  EXPECT_EQ(
-      "Read and change your data on encrypted.google.com and www.google.com",
-      UTF16ToUTF8(warnings[0]));
+  EXPECT_TRUE(VerifyOnePermissionMessage(
+      extension->permissions_data(),
+      "Read and change your data on encrypted.google.com and www.google.com"));
 }
 
 TEST(PermissionsDataTest, GetPermissionMessages_Plugins) {
   scoped_refptr<Extension> extension;
   extension = LoadManifest("permissions", "plugins.json");
-  std::vector<base::string16> warnings =
-      extension->permissions_data()->GetPermissionMessageStrings();
 // We don't parse the plugins key on Chrome OS, so it should not ask for any
 // permissions.
 #if defined(OS_CHROMEOS)
-  ASSERT_EQ(0u, warnings.size());
+  EXPECT_TRUE(VerifyNoPermissionMessages(extension->permissions_data()));
 #else
-  ASSERT_EQ(1u, warnings.size());
-  EXPECT_EQ(
+  EXPECT_TRUE(VerifyOnePermissionMessage(
+      extension->permissions_data(),
       "Read and change all your data on your computer and the websites you "
-      "visit",
-      UTF16ToUTF8(warnings[0]));
+      "visit"));
 #endif
 }
 
 TEST(PermissionsDataTest, ExternalFiles) {
   GURL external_file("externalfile:abc");
   scoped_refptr<const Extension> extension;
 
   // A regular extension shouldn't get access to externalfile: scheme URLs
   // even with <all_urls> specified.
   extension = GetExtensionWithHostPermission(
@@ skipping 406 matching lines @@
 
   permissions_data->ClearTabSpecificPermissions(1);
   EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(1).get());
 
   EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0));
   EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 1));
   EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2));
 }
 
 }  // namespace extensions