Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

Issue 980353003: Extensions: Switch to new permission message system, part I (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/permissions/chrome_permission_message_rules.h " 5 #include "chrome/common/extensions/permissions/chrome_permission_message_rules.h "
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "chrome/grit/generated_resources.h" 9 #include "chrome/grit/generated_resources.h"
10 #include "extensions/common/permissions/api_permission_set.h" 10 #include "extensions/common/permissions/api_permission_set.h"
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 {APIPermission::kFullAccess}, 258 {APIPermission::kFullAccess},
259 {APIPermission::kHostsAll, 259 {APIPermission::kHostsAll,
260 APIPermission::kHostsAllReadOnly, 260 APIPermission::kHostsAllReadOnly,
261 APIPermission::kDeclarativeWebRequest, 261 APIPermission::kDeclarativeWebRequest,
262 APIPermission::kTopSites, 262 APIPermission::kTopSites,
263 APIPermission::kTab}}, 263 APIPermission::kTab}},
264 264
265 // Parameterized permission messages: 265 // Parameterized permission messages:
266 // Messages generated by the sockets permission. 266 // Messages generated by the sockets permission.
267 {new SpaceSeparatedListFormatter( 267 {new SpaceSeparatedListFormatter(
268 IDS_EXTENSION_PROMPT_WARNING_SOCKET_HOSTS_IN_DOMAIN,
269 IDS_EXTENSION_PROMPT_WARNING_SOCKET_HOSTS_IN_DOMAINS),
270 {APIPermission::kSocketDomainHosts},
271 {}},
272 {new SpaceSeparatedListFormatter(
268 IDS_EXTENSION_PROMPT_WARNING_SOCKET_SPECIFIC_HOST, 273 IDS_EXTENSION_PROMPT_WARNING_SOCKET_SPECIFIC_HOST,
269 IDS_EXTENSION_PROMPT_WARNING_SOCKET_SPECIFIC_HOSTS), 274 IDS_EXTENSION_PROMPT_WARNING_SOCKET_SPECIFIC_HOSTS),
270 {APIPermission::kSocketSpecificHosts}, 275 {APIPermission::kSocketSpecificHosts},
271 {}}, 276 {}},
272 {new SpaceSeparatedListFormatter(
273 IDS_EXTENSION_PROMPT_WARNING_SOCKET_HOSTS_IN_DOMAIN,
274 IDS_EXTENSION_PROMPT_WARNING_SOCKET_HOSTS_IN_DOMAINS),
275 {APIPermission::kSocketDomainHosts},
276 {}},
277 277
278 // Messages generated by host permissions. 278 // Messages generated by host permissions.
279 {new CommaSeparatedListFormatter( 279 {new CommaSeparatedListFormatter(
280 IDS_EXTENSION_PROMPT_WARNING_1_HOST_READ_ONLY, 280 IDS_EXTENSION_PROMPT_WARNING_1_HOST_READ_ONLY,
281 IDS_EXTENSION_PROMPT_WARNING_2_HOSTS_READ_ONLY, 281 IDS_EXTENSION_PROMPT_WARNING_2_HOSTS_READ_ONLY,
282 IDS_EXTENSION_PROMPT_WARNING_3_HOSTS_READ_ONLY, 282 IDS_EXTENSION_PROMPT_WARNING_3_HOSTS_READ_ONLY,
283 IDS_EXTENSION_PROMPT_WARNING_HOSTS_LIST_READ_ONLY), 283 IDS_EXTENSION_PROMPT_WARNING_HOSTS_LIST_READ_ONLY),
284 {APIPermission::kHostReadOnly}, 284 {APIPermission::kHostReadOnly},
285 {}}, 285 {}},
286 {new CommaSeparatedListFormatter(IDS_EXTENSION_PROMPT_WARNING_1_HOST, 286 {new CommaSeparatedListFormatter(IDS_EXTENSION_PROMPT_WARNING_1_HOST,
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 APIPermission::kMediaGalleriesAllGalleriesRead}, 340 APIPermission::kMediaGalleriesAllGalleriesRead},
341 {}}, 341 {}},
342 {IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_READ, 342 {IDS_EXTENSION_PROMPT_WARNING_MEDIA_GALLERIES_READ,
343 {APIPermission::kMediaGalleriesAllGalleriesRead}, 343 {APIPermission::kMediaGalleriesAllGalleriesRead},
344 {}}, 344 {}},
345 345
346 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE_AND_SESSIONS, 346 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE_AND_SESSIONS,
347 {APIPermission::kSessions, APIPermission::kHistory}, 347 {APIPermission::kSessions, APIPermission::kHistory},
348 {APIPermission::kTab, 348 {APIPermission::kTab,
349 APIPermission::kFavicon, 349 APIPermission::kFavicon,
350 APIPermission::kTopSites}}, 350 APIPermission::kProcesses,
351 APIPermission::kTopSites,
352 APIPermission::kWebNavigation}},
351 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ_AND_SESSIONS, 353 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_READ_AND_SESSIONS,
352 {APIPermission::kSessions, APIPermission::kTab}, 354 {APIPermission::kSessions, APIPermission::kTab},
353 {APIPermission::kFavicon, APIPermission::kTopSites}}, 355 {APIPermission::kFavicon,
356 APIPermission::kProcesses,
357 APIPermission::kTopSites,
358 APIPermission::kWebNavigation}},
354 359
355 // Suppression list taken from 360 // Suppression list taken from
356 // ChromePermissionMessageProvider::GetPermissionMessages(): 361 // ChromePermissionMessageProvider::GetPermissionMessages():
357 // Some warnings are more generic and/or powerful and supercede other 362 // Some warnings are more generic and/or powerful and supercede other
358 // warnings. In that case, the first message suppresses the second one. 363 // warnings. In that case, the first message suppresses the second one.
359 {IDS_EXTENSION_PROMPT_WARNING_BLUETOOTH, 364 {IDS_EXTENSION_PROMPT_WARNING_BLUETOOTH,
360 {APIPermission::kBluetooth}, 365 {APIPermission::kBluetooth},
361 {APIPermission::kBluetoothDevices}}, 366 {APIPermission::kBluetoothDevices}},
362 {IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS, 367 {IDS_EXTENSION_PROMPT_WARNING_BOOKMARKS,
363 {APIPermission::kBookmark}, 368 {APIPermission::kBookmark},
364 {APIPermission::kOverrideBookmarksUI}}, 369 {APIPermission::kOverrideBookmarksUI}},
365 // History already allows reading favicons, tab access and accessing the 370 // History already allows reading favicons, tab access and accessing the
366 // list of most frequently visited sites. 371 // list of most frequently visited sites.
367 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE, 372 {IDS_EXTENSION_PROMPT_WARNING_HISTORY_WRITE,
368 {APIPermission::kHistory}, 373 {APIPermission::kHistory},
369 {APIPermission::kFavicon, 374 {APIPermission::kFavicon,
370 APIPermission::kTab, 375 APIPermission::kTab,
371 APIPermission::kFavicon,
372 APIPermission::kTopSites}}, 376 APIPermission::kTopSites}},
373 // A special hack: If kFileSystemWriteDirectory would be displayed, hide 377 // A special hack: If kFileSystemWriteDirectory would be displayed, hide
374 // kFileSystemDirectory as the write directory message implies it. 378 // kFileSystemDirectory as the write directory message implies it.
375 // TODO(sashab): Remove kFileSystemWriteDirectory; it's no longer needed 379 // TODO(sashab): Remove kFileSystemWriteDirectory; it's no longer needed
376 // since this rules system can represent the rule. See crbug.com/284849. 380 // since this rules system can represent the rule. See crbug.com/284849.
377 {IDS_EXTENSION_PROMPT_WARNING_FILE_SYSTEM_WRITE_DIRECTORY, 381 {IDS_EXTENSION_PROMPT_WARNING_FILE_SYSTEM_WRITE_DIRECTORY,
378 {APIPermission::kFileSystemWrite, APIPermission::kFileSystemDirectory}, 382 {APIPermission::kFileSystemWrite, APIPermission::kFileSystemDirectory},
379 {APIPermission::kFileSystemWriteDirectory}}, 383 {APIPermission::kFileSystemWriteDirectory}},
380 // Full access already allows DeclarativeWebRequest, reading the list of 384 // Full access already allows DeclarativeWebRequest, reading the list of
381 // most frequently visited sites, and tab access. 385 // most frequently visited sites, and tab access.
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
653 insert(permission_four); 657 insert(permission_four);
654 insert(permission_five); 658 insert(permission_five);
655 insert(permission_six); 659 insert(permission_six);
656 } 660 }
657 661
658 ChromePermissionMessageRule::PermissionIDSetInitializer:: 662 ChromePermissionMessageRule::PermissionIDSetInitializer::
659 ~PermissionIDSetInitializer() { 663 ~PermissionIDSetInitializer() {
660 } 664 }
661 665
662 } // namespace extensions 666 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698