Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 980343002: Skip removal of stylesheet candidate node if not added. (Closed)

Created:
5 years, 9 months ago by rune
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Skip removal of stylesheet candidate node if not added. There is a flag saying whether it was added which was already in use in StyleElement::removedFrom. Also removed an unnecessary test and bogus comment for HTMLLinkElement. StyleElement is only used by HTMLStyleElement and SVGStyleElement. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191792

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/dom/StyleElement.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rune
5 years, 9 months ago (2015-03-05 23:08:35 UTC) #2
rune
PTAL
5 years, 9 months ago (2015-03-12 08:12:34 UTC) #3
dglazkov
lgtm
5 years, 9 months ago (2015-03-12 14:52:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980343002/20001
5 years, 9 months ago (2015-03-12 14:53:22 UTC) #7
rune
On 2015/03/12 14:52:58, dglazkov wrote: > lgtm thanks!
5 years, 9 months ago (2015-03-12 15:00:04 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 19:15:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191792

Powered by Google App Engine
This is Rietveld 408576698