Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 980333004: Removing unused Births methods and unnecessary link from chrome://profiler (Closed)

Created:
5 years, 9 months ago by vadimt
Modified:
5 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@reset_max
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing unused Births methods and unnecessary link from chrome://profiler. Removing [Reset tracking data] was approved by jar@. It was never fully implemented (only for the browser process) and is superseded by taking and comparing snapshots in chrome://profiler tab. BUG=456354 Committed: https://crrev.com/0b8f5a8f335e6de9e80e13e315b4e3f7f6460079 Cr-Commit-Position: refs/heads/master@{#319770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -62 lines) Patch
M base/tracked_objects.h View 3 chunks +0 lines, -16 lines 0 comments Download
M base/tracked_objects.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/resources/profiler/profiler.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/profiler/profiler.js View 4 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/ui/webui/profiler_ui.cc View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
vadimt
isherman@, please pre-review
5 years, 9 months ago (2015-03-05 23:57:27 UTC) #2
Ilya Sherman
LGTM
5 years, 9 months ago (2015-03-06 00:07:27 UTC) #3
vadimt
cpu@chromium.org: Please provide OWNER's approval
5 years, 9 months ago (2015-03-06 00:08:43 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
5 years, 9 months ago (2015-03-09 20:24:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980333004/1
5 years, 9 months ago (2015-03-09 20:24:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 23:36:32 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:37:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b8f5a8f335e6de9e80e13e315b4e3f7f6460079
Cr-Commit-Position: refs/heads/master@{#319770}

Powered by Google App Engine
This is Rietveld 408576698