Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 98033003: Support missing and invalid defaults for reflected attributes. (Closed)

Created:
6 years, 11 months ago by sof
Modified:
6 years, 10 months ago
CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support missing and invalid defaults for reflected attributes. Some enumerated attributes have a designated state if the underlying attribute value is either missing or in an invalid state. That state should be observable for reflected IDL attributes on getting, hence add support for controlling what values to use for these attribute states: [ReflectMissing=missingValue] [ReflectInvalid=invalidValue] The attributes only have an interpretation for limited DOMString attributes that use [ReflectOnly=<list>]. The missing/invalid value defaults must appear in the ReflectOnly list. R= BUG=331694 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164579

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use same idiom for looking up value in array #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -5 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.pm View 1 4 chunks +26 lines, -5 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 2 chunks +122 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look when you next have a spare moment. 2nd (and final) reflection ...
6 years, 11 months ago (2014-01-07 10:39:02 UTC) #1
haraken
LGTM https://codereview.chromium.org/98033003/diff/1/Source/bindings/scripts/code_generator_v8.pm File Source/bindings/scripts/code_generator_v8.pm (right): https://codereview.chromium.org/98033003/diff/1/Source/bindings/scripts/code_generator_v8.pm#newcode6269 Source/bindings/scripts/code_generator_v8.pm:6269: if (!($missingValueDefault ~~ @knownValues)) { Nit: I'd prefer ...
6 years, 11 months ago (2014-01-07 10:48:18 UTC) #2
sof
https://codereview.chromium.org/98033003/diff/1/Source/bindings/scripts/code_generator_v8.pm File Source/bindings/scripts/code_generator_v8.pm (right): https://codereview.chromium.org/98033003/diff/1/Source/bindings/scripts/code_generator_v8.pm#newcode6269 Source/bindings/scripts/code_generator_v8.pm:6269: if (!($missingValueDefault ~~ @knownValues)) { On 2014/01/07 10:48:19, haraken ...
6 years, 11 months ago (2014-01-07 11:40:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/98033003/60001
6 years, 11 months ago (2014-01-07 11:41:13 UTC) #4
commit-bot: I haz the power
Change committed as 164579
6 years, 11 months ago (2014-01-07 13:17:08 UTC) #5
Nils Barth (inactive)
6 years, 10 months ago (2014-02-05 06:30:56 UTC) #6
Message was sent while issue was closed.
Python side in:
IDL compiler: [ReflectMissing], [ReflectInvalid]
https://codereview.chromium.org/152043003/

Powered by Google App Engine
This is Rietveld 408576698