Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 980323003: Clean up examples directory (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Clean up examples directory This CL removes a bunch of examples that don't actually work in the current engine. I've also renamed example-element to custom-element and example-scrollable to scrolling because the word "example" in the name is redundant with the name of the directory. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c6253e72977e7804dff7474a4cbcfb966ff9bf48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2208 lines) Patch
D sky/examples/README.md View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/examples/city-list/city-data-service.sky View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/examples/city-list/city-list.sky View 1 chunk +0 lines, -532 lines 0 comments Download
D sky/examples/city-list/city-sequence.sky View 1 chunk +0 lines, -64 lines 0 comments Download
D sky/examples/city-list/index.sky View 1 chunk +0 lines, -52 lines 0 comments Download
A + sky/examples/custom-element/example-element.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/examples/custom-element/index.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/examples/dart-mojo.sky View 1 chunk +0 lines, -82 lines 0 comments Download
D sky/examples/example-element/example-element.sky View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/examples/example-element/index.sky View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/examples/example-scrollable/example-scrollable.sky View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/examples/example-scrollable/index.sky View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/examples/flights-app/app-header.sky View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/examples/flights-app/app-menu-button.sky View 1 chunk +0 lines, -21 lines 0 comments Download
D sky/examples/flights-app/app-panel.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/examples/flights-app/app-panel-content.sky View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/examples/flights-app/app-panel-header.sky View 1 chunk +0 lines, -19 lines 0 comments Download
D sky/examples/flights-app/app-scrollable.sky View 1 chunk +0 lines, -18 lines 0 comments Download
D sky/examples/flights-app/app-search-input.sky View 1 chunk +0 lines, -32 lines 0 comments Download
D sky/examples/flights-app/app-title.sky View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/examples/flights-app/app-toast.sky View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/examples/flights-app/app-toolbar.sky View 1 chunk +0 lines, -17 lines 0 comments Download
D sky/examples/flights-app/flights-app.sky View 1 chunk +0 lines, -208 lines 0 comments Download
D sky/examples/flights-app/index.sky View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/examples/fps-counter.sky View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/examples/htmlish/framework/element.sky View 1 chunk +0 lines, -70 lines 0 comments Download
D sky/examples/htmlish/framework/htmlish.sky View 1 chunk +0 lines, -112 lines 0 comments Download
D sky/examples/htmlish/samples/intro.sky View 1 chunk +0 lines, -11 lines 0 comments Download
A + sky/examples/scrolling/index.sky View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/examples/scrolling/scrolling.sky View 3 chunks +4 lines, -4 lines 0 comments Download
D sky/examples/shell/sensor.sky View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/examples/style/block-layout.sky View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/examples/style/hex-layout.sky View 1 chunk +0 lines, -152 lines 0 comments Download
D sky/examples/style/sky-core-styles.sky View 1 chunk +0 lines, -143 lines 0 comments Download
D sky/examples/style/toolbar-layout.sky View 1 chunk +0 lines, -214 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-05 17:02:24 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-05 17:52:36 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-05 17:55:59 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c6253e72977e7804dff7474a4cbcfb966ff9bf48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698