Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 980273002: Revert of Add image as a draw type that can be filtered (Closed)

Created:
5 years, 9 months ago by Kimmo Kinnunen
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@skimage-filters-04-snapshot-devices-and-use-snapshots-in-skcanvas
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add image as a draw type that can be filtered (patchset #4 id:60001 of https://codereview.chromium.org/960783003/) Reason for revert: Fails on mac for some reason. Also is a bit wrong, but this should not be reason for the failure.. Original issue's description: > Add image as a draw type that can be filtered > > Add image as a draw type that can be filtered. > > This is needed when SkImage is added as an object to be drawn so that > the draw is forwarded to SkBaseDevice. This would be used in making > filters use SkImages. > > BUG=skia:3388 > > Committed: https://skia.googlesource.com/skia/+/fa77eb1e51b9317ff993d1be504ada173b561e5f TBR=reed@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3388 Committed: https://skia.googlesource.com/skia/+/a9baa652bb329b5a286e1638938f63433701efca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -203 lines) Patch
M include/core/SkDrawFilter.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +3 lines, -52 lines 0 comments Download
M tests/SkImageTest.cpp View 2 chunks +0 lines, -144 lines 0 comments Download
M tools/bench_pictures_main.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Kimmo Kinnunen
Created Revert of Add image as a draw type that can be filtered
5 years, 9 months ago (2015-03-05 12:49:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980273002/1
5 years, 9 months ago (2015-03-05 12:49:52 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-05 12:49:53 UTC) #3
Kimmo Kinnunen
add mtklein for being an early bird, joshualitt for being the sheriff..
5 years, 9 months ago (2015-03-05 12:50:40 UTC) #5
mtklein
lgtm
5 years, 9 months ago (2015-03-05 14:32:51 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 14:33:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a9baa652bb329b5a286e1638938f63433701efca

Powered by Google App Engine
This is Rietveld 408576698