Source/core/css/parser/CSSPropertyParser.cpp - Issue 980233002: [svg2] Make 'cx', 'cy' and 'r' presentation attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 980233002: [svg2] Make 'cx', 'cy' and 'r' presentation attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/svg/css/parse-length.html ('K') | « Source/core/css/parser/CSSParserFastPaths.cpp ('k') | Source/core/css/resolver/AnimatedStyleBuilder.cpp » ('j') | Source/core/layout/style/SVGLayoutStyleDefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp

index 1e5526450dc163a9ac2d984ccd298efac6ab5536..a37c133d4b468868a52c4abbd2f564fcf1eef370 100644

--- a/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/Source/core/css/parser/CSSPropertyParser.cpp

@@ -8127,8 +8127,11 @@ bool CSSPropertyParser::parseSVGValue(CSSPropertyID propId, bool important)

if (id == CSSValueLuminance || id == CSSValueAlpha)

validPrimitive = true;

break;

+ case CSSPropertyCx:

+ case CSSPropertyCy:

case CSSPropertyX:

case CSSPropertyY:

+ case CSSPropertyR:

case CSSPropertyRx:

case CSSPropertyRy:

validPrimitive = (!id && validUnit(value, FLength | FPercent, SVGAttributeMode));