Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: tests/InvalidIndexedPngTest.cpp

Issue 980203005: Revert of Fix a memory leak when decoding corrupted indexed PNGs. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/images/SkImageDecoder_libpng.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/InvalidIndexedPngTest.cpp
diff --git a/tests/InvalidIndexedPngTest.cpp b/tests/InvalidIndexedPngTest.cpp
deleted file mode 100644
index ba5b9a27afde7e9b7a0572bf0f2dfb669259eca9..0000000000000000000000000000000000000000
--- a/tests/InvalidIndexedPngTest.cpp
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * Copyright 2015 Google Inc.
- *
- * Use of this source code is governed by a BSD-style license that can be
- * found in the LICENSE file.
- */
-
-#include "SkBitmap.h"
-#include "SkForceLinking.h"
-#include "SkImageDecoder.h"
-#include "Test.h"
-
-// A valid 1x1 indexed PNG.
-unsigned char gPngData[] = {
- 0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a, 0x00, 0x00, 0x00, 0x0d,
- 0x49, 0x48, 0x44, 0x52, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x01,
- 0x08, 0x03, 0x00, 0x00, 0x00, 0x28, 0xcb, 0x34, 0xbb, 0x00, 0x00, 0x00,
- 0x09, 0x70, 0x48, 0x59, 0x73, 0x00, 0x00, 0x00, 0x1c, 0x00, 0x00, 0x00,
- 0x1c, 0x00, 0x0f, 0x01, 0xb9, 0x8f, 0x00, 0x00, 0x00, 0x06, 0x50, 0x4c,
- 0x54, 0x45, 0xff, 0x00, 0x00, 0x00, 0xff, 0x00, 0xd2, 0x87, 0xef, 0x71,
- 0x00, 0x00, 0x00, 0x13, 0x49, 0x44, 0x41, 0x54, 0x78, 0xda, 0xed, 0xfd,
- 0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x10, 0xf8, 0xaf, 0x16, 0x46, 0x00,
- 0x02, 0x00, 0x01, 0x32, 0x60, 0xf7, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x49,
- 0x45, 0x4e, 0x44, 0xae, 0x42, 0x60, 0x82
-};
-
-// Attempt to decode an invalid PNG that has a palette. Mostly we're looking to
-// make sure we don't leak memory since libpng uses setjmp for error handling so
-// it's very easy to accidentally skip destructors when a failure happens.
-DEF_TEST(InvalidIndexedPng, reporter) {
- SkBitmap image;
- SkForceLinking(false);
- // Make our PNG invalid by changing a byte.
- gPngData[sizeof(gPngData) - 1] = 1;
- bool success = SkImageDecoder::DecodeMemory(
- gPngData, sizeof(gPngData), &image, SkColorType::kUnknown_SkColorType,
- SkImageDecoder::kDecodePixels_Mode);
- REPORTER_ASSERT(reporter, !success);
-}
« no previous file with comments | « src/images/SkImageDecoder_libpng.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698