Issue 980203005: Revert of Fix a memory leak when decoding corrupted indexed PNGs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 980203005: Revert of Fix a memory leak when decoding corrupted indexed PNGs. (Closed)

Created:
5 years, 9 months ago by reed2

Modified:
5 years, 9 months ago

Reviewers:
scroggo, David Lattimore

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Fix a memory leak when decoding corrupted indexed PNGs. (patchset #2 id:20001 of https://codereview.chromium.org/951663002/) Reason for revert: speculative revert due to many failures in tree Original issue's description: > Fix a memory leak when decoding corrupted indexed PNGs. > Commit to branch refs/heads/png-leak > > BUG=skia:3457 > > Committed: https://skia.googlesource.com/skia/+/561a1ca9559a1ea7589ab93350124284fcef3315 TBR=scroggo@google.com,dml@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3457 Committed: https://skia.googlesource.com/skia/+/8371b7e8ef62f23f56ba56e4d96eb0756a8a303c

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -46 lines)			Patch
M	gyp/tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/images/SkImageDecoder_libpng.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
D	tests/InvalidIndexedPngTest.cpp	View	1 chunk	+0 lines, -39 lines	0 comments	Download

Total messages: 3 (0 generated)

reed2

Created Revert of Fix a memory leak when decoding corrupted indexed PNGs.

5 years, 9 months ago (2015-03-07 14:05:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980203005/1

5 years, 9 months ago (2015-03-07 14:05:43 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-07 14:05:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8371b7e8ef62f23f56ba56e4d96eb0756a8a303c