Issue 980103002: Disable infer-from-overrides by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 980103002: Disable infer-from-overrides by default (Closed)

Created:
5 years, 9 months ago by vsm

Modified:
5 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
dev-compiler+reviews_dartlang.org

Base URL:
https://github.com/dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Disable infer-from-overrides by default See: https://github.com/dart-lang/dev_compiler/issues/86 R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/75802caae15763709b9a80b873149f980a93ec8c

Patch Set 2 : Reformat #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
M	lib/src/codegen/js_codegen.dart	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	lib/src/options.dart	View		4 chunks	+7 lines, -3 lines	0 comments	Download
M	lib/src/testing.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/checker/checker_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

https://codereview.chromium.org/980103002/diff/1/lib/src/options.dart File lib/src/options.dart (right): https://codereview.chromium.org/980103002/diff/1/lib/src/options.dart#newcode28 lib/src/options.dart:28: static const bool INFER_FROM_OVERRIDES_DEFAULT = false; Trying to make ...

5 years, 9 months ago (2015-03-05 03:58:56 UTC) #2

vsm

5 years, 9 months ago (2015-03-05 20:27:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
75802caae15763709b9a80b873149f980a93ec8c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 980103002: Disable infer-from-overrides by default (Closed)

Description

Patch Set 1 #

Patch Set 2 : Reformat #

Messages