tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py - Issue 980073006: Telemetry: devtools_http should reuse its http connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

Issue 980073006: Telemetry: devtools_http should reuse its http connection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from dtu, round two. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

index 347bcb6f73ff2b3cf4df2c1b00dfab591abf333c..06124804e343d35e4142b1233b43b24b5e0aa33b 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py

@@ -15,7 +15,11 @@ from telemetry.core.platform.tracing_agent import chrome_tracing_agent

def IsDevToolsAgentAvailable(port):

"""Returns True if a DevTools agent is available on the given port."""

- return _IsDevToolsAgentAvailable(devtools_http.DevToolsHttp(port))

+ devtools_http_instance = devtools_http.DevToolsHttp(port)

+ try:

+ return _IsDevToolsAgentAvailable(devtools_http.DevToolsHttp(port))

+ finally:

+ devtools_http_instance.Disconnect()

# TODO(nednguyen): Find a more reliable way to check whether the devtool agent

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_http.py » ('j') | no next file with comments »