Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Issue 980053002: Remove some duplicate code / constants in pdf/. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some duplicate code / constants in pdf/. They were previously duplicated so the PDF module didn't have to depend on code in printing/, but now the PDF module has been merged into the main chrome binary. Committed: https://crrev.com/16f763ce6608ade84839d6299a68070673fac9aa Cr-Commit-Position: refs/heads/master@{#319225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -33 lines) Patch
M pdf/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 9 chunks +28 lines, -33 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
5 years, 9 months ago (2015-03-05 01:20:36 UTC) #2
jam
lgtm
5 years, 9 months ago (2015-03-05 01:48:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980053002/1
5 years, 9 months ago (2015-03-05 02:20:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/41306)
5 years, 9 months ago (2015-03-05 04:29:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/980053002/1
5 years, 9 months ago (2015-03-05 05:03:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 06:06:10 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 06:07:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16f763ce6608ade84839d6299a68070673fac9aa
Cr-Commit-Position: refs/heads/master@{#319225}

Powered by Google App Engine
This is Rietveld 408576698