Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 979973002: [Android] Don't build remoting_unittests. (Closed)

Created:
5 years, 9 months ago by jbudorick
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Don't build remoting_unittests. It doesn't build in gyp configurations, either: https://code.google.com/p/chromium/codesearch#chromium/src/build/all.gyp&l=342 TBR=brettw@chromium.org BUG=464031 Committed: https://crrev.com/3faa1e0dad24335471c1c9780fa04a602d87417e Cr-Commit-Position: refs/heads/master@{#319136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jbudorick
5 years, 9 months ago (2015-03-04 21:01:24 UTC) #2
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-04 21:08:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979973002/1
5 years, 9 months ago (2015-03-04 21:33:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/47337)
5 years, 9 months ago (2015-03-04 21:57:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979973002/1
5 years, 9 months ago (2015-03-04 22:01:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 22:08:42 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 22:09:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3faa1e0dad24335471c1c9780fa04a602d87417e
Cr-Commit-Position: refs/heads/master@{#319136}

Powered by Google App Engine
This is Rietveld 408576698