Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3002)

Unified Diff: chrome/browser/net/chrome_fraudulent_certificate_reporter.h

Issue 979893003: Refactor ChromeFraudulentCertReporter for code reuse by SSL reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use URLRequestMockDataJob to avoid IO in unit test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_fraudulent_certificate_reporter.h
diff --git a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
index c9874768f1e818aeccfa58e670851e2dfc4f55ed..86575eaaa2540aa4b39f969c1a5eb0d30e06cd61 100644
--- a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
+++ b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h
@@ -8,8 +8,8 @@
#include <set>
#include <string>
+#include "base/memory/scoped_ptr.h"
#include "net/url_request/fraudulent_certificate_reporter.h"
-#include "net/url_request/url_request.h"
namespace net {
class URLRequestContext;
@@ -17,38 +17,26 @@ class URLRequestContext;
namespace chrome_browser_net {
+class CertificateErrorReporter;
+
class ChromeFraudulentCertificateReporter
- : public net::FraudulentCertificateReporter,
- public net::URLRequest::Delegate {
+ : public net::FraudulentCertificateReporter {
public:
explicit ChromeFraudulentCertificateReporter(
net::URLRequestContext* request_context);
- ~ChromeFraudulentCertificateReporter() override;
+ // Useful for tests to use a mock reporter.
+ explicit ChromeFraudulentCertificateReporter(
+ scoped_ptr<CertificateErrorReporter> certificate_reporter);
- // Allows users of this class to override this and set their own URLRequest
- // type. Used by SendReport.
- virtual scoped_ptr<net::URLRequest> CreateURLRequest(
- net::URLRequestContext* context);
+ ~ChromeFraudulentCertificateReporter() override;
// net::FraudulentCertificateReporter
void SendReport(const std::string& hostname,
const net::SSLInfo& ssl_info) override;
- // net::URLRequest::Delegate
- void OnResponseStarted(net::URLRequest* request) override;
- void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
-
- protected:
- net::URLRequestContext* const request_context_;
-
private:
- // Performs post-report cleanup.
- void RequestComplete(net::URLRequest* request);
-
- const GURL upload_url_;
- // Owns the contained requests.
- std::set<net::URLRequest*> inflight_requests_;
+ scoped_ptr<CertificateErrorReporter> certificate_reporter_;
DISALLOW_COPY_AND_ASSIGN(ChromeFraudulentCertificateReporter);
};
@@ -56,4 +44,3 @@ class ChromeFraudulentCertificateReporter
} // namespace chrome_browser_net
#endif // CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_
-

Powered by Google App Engine
This is Rietveld 408576698