chrome/browser/net/cert_logger.proto - Issue 979893003: Refactor ChromeFraudulentCertReporter for code reuse by SSL reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/cert_logger.proto

Issue 979893003: Refactor ChromeFraudulentCertReporter for code reuse by SSL reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: document test_mail_google_com.pem format, add a RunUntilIdle, style fixes Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/net/cert_logger.proto

diff --git a/chrome/browser/net/cert_logger.proto b/chrome/browser/net/cert_logger.proto

index be95005b70d2defe857551e8b7c2c95456ea0124..b42c5df7d5054c04d59d569322ddb5eacc0295b3 100644

--- a/chrome/browser/net/cert_logger.proto

+++ b/chrome/browser/net/cert_logger.proto

@@ -3,11 +3,12 @@

// found in the LICENSE file.

// This protobuffer is intended to store reports from Chrome users of

-// certificate pinning errors. A report will be sent from Chrome when it gets

+// certificate errors. A report will be sent from Chrome when it gets

// e.g. a certificate for google.com that chains up to a root CA not expected by

// Chrome for that origin, such as DigiNotar (compromised in July 2011), or

-// other pinning errors such as a blacklisted cert in the chain. The

-// report from the user will include the hostname being accessed,

+// other pinning errors such as a blacklisted cert in the chain, or

+// (when opted in) other certificate validation errors like an expired

+// cert. The report from the user will include the hostname being accessed,

// the full certificate chain (in PEM format), and the

// timestamp of when the client tried to access the site. A response is

// generated by the frontend and logged, including validation and error checking

« no previous file with comments | « no previous file | chrome/browser/net/certificate_error_reporter.h » ('j') | chrome/browser/net/certificate_error_reporter.cc » ('J')