Refactor ChromeFraudulentCertReporter for code reuse by SSL reporting

chrome/browser/net/certificate_error_reporter_unittest.cc

Index: chrome/browser/net/certificate_error_reporter_unittest.cc
diff --git a/chrome/browser/net/certificate_error_reporter_unittest.cc b/chrome/browser/net/certificate_error_reporter_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fbfa257c8ae7a709bc5dbf9955c94686612b0918
--- /dev/null
+++ b/chrome/browser/net/certificate_error_reporter_unittest.cc
@@ -0,0 +1,219 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/net/certificate_error_reporter.h"
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/files/file_path.h"
+#include "base/files/file_util.h"
+#include "base/path_service.h"
+#include "base/run_loop.h"
+#include "base/thread_task_runner_handle.h"
+#include "chrome/browser/net/cert_logger.pb.h"
+#include "chrome/browser/net/url_request_mock_util.h"
+#include "chrome/common/chrome_paths.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "net/base/network_delegate_impl.h"
+#include "net/base/test_data_directory.h"
+#include "net/test/cert_test_util.h"
+#include "net/test/url_request/url_request_failed_job.h"
+#include "net/test/url_request/url_request_mock_http_job.h"
+#include "net/url_request/url_request_filter.h"
+#include "net/url_request/url_request_test_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using chrome_browser_net::CertificateErrorReporter;
+using content::BrowserThread;
+using net::CompletionCallback;
+using net::SSLInfo;
+using net::NetworkDelegateImpl;
+using net::TestURLRequestContext;
+using net::URLRequest;
+
+namespace {
+
+const char kHostname[] = "test.mail.google.com";
+const char kDummyFailureLog[] = "dummy failure log";
+const char kTestCertFilename[] = FILE_PATH_LITERAL("test_mail_google_com.pem");
+
+SSLInfo GetSSLInfo() {
+  SSLInfo info;
+  info.cert =
+      net::ImportCertFromFile(net::GetTestCertsDirectory(), kTestCertFilename);
+  info.is_issued_by_known_root = true;
+  info.pinning_failure_log = kDummyFailureLog;
+  return info;
+}
+
+std::string GetPEMEncodedChain() {
+  base::FilePath cert_path =
+      net::GetTestCertsDirectory().AppendASCII(kTestCertFilename);
+  std::string cert_data;
+  EXPECT_TRUE(base::ReadFileToString(cert_path, &cert_data));
+  return cert_data;
+}
+
+void EnableUrlRequestMocks(bool enable) {
+  net::URLRequestFilter::GetInstance()->ClearHandlers();
+  if (enable) {
+    base::FilePath root_http;
+    net::URLRequestFailedJob::AddUrlHandler();
+    PathService::Get(chrome::DIR_TEST_DATA, &root_http);
+    net::URLRequestMockHTTPJob::AddUrlHandlers(
+        root_http, BrowserThread::GetBlockingPool());
+  }
+}
+
+// A network delegate that lets tests check that requests were created
+// or destroyed.
+class TestNetworkDelegate : public NetworkDelegateImpl {
+ public:
+  TestNetworkDelegate() : NetworkDelegateImpl() {
+    requests_ = 0;
+    destroyed_requests_ = 0;
+  }
+  ~TestNetworkDelegate() {}
+
+  int OnBeforeURLRequest(URLRequest* request,
+                         const CompletionCallback& callback,
+                         GURL* new_url) override {
+    requests_++;
+    return net::OK;
+  }
+
+  void OnURLRequestDestroyed(URLRequest* request) { destroyed_requests_++; }
+
+  int GetNumRequests() { return requests_; }
+  int GetNumDestroyedRequests() { return destroyed_requests_; }
+
+ private:
+  int requests_;
+  int destroyed_requests_;
+};
+
+class CertificateErrorReporterTest : public ::testing::Test {
+ public:
+  ~CertificateErrorReporterTest() {
+    EnableUrlRequestMocks(false);
+    chrome_browser_net::SetUrlRequestMocksEnabled(false);
+  }
+
+ protected:
+  CertificateErrorReporterTest() : context_(true) {
+    EnableUrlRequestMocks(true);
+    context_.set_network_delegate(&network_delegate_);
+    context_.Init();
+  }
+
+  TestURLRequestContext context_;
+  TestNetworkDelegate network_delegate_;
+
+  content::TestBrowserThreadBundle thread_bundle_;

[Ryan Sleevi, 2015/03/09 23:44:56]

Should make sure this is the first member, since either lines 111 or 112 may
attempt to use BrowserThread and would fail.

[estark, 2015/03/10 00:07:38]

Done.

+};
+
+class TestReporter : public CertificateErrorReporter {
+ public:
+  TestReporter(net::URLRequestContext* context, const GURL& upload_url)
+      : CertificateErrorReporter(context, upload_url), latest_request_url_() {
+    response_started_callback_ = base::Bind(&base::DoNothing);
+  }
+
+  TestReporter(net::URLRequestContext* context,
+               const GURL& upload_url,
+               base::Closure response_started_callback)
+      : CertificateErrorReporter(context, upload_url),
+        latest_request_url_(),
+        response_started_callback_(response_started_callback) {}
+
+  void OnResponseStarted(net::URLRequest* request) override {
+    latest_request_url_ = request->url();
+    CertificateErrorReporter::OnResponseStarted(request);
+    base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
+                                                  response_started_callback_);
+  }
+
+  GURL& GetLatestRequestURL() { return latest_request_url_; }
+
+ private:
+  GURL latest_request_url_;
+  base::Closure response_started_callback_;
+};
+
+// Test that CertificateErrorReporter::SendReport creates a URLRequest
+// for the endpoint.
+TEST_F(CertificateErrorReporterTest, SendReportSendsRequest) {
+  base::RunLoop run_loop;
+  base::Closure callback = run_loop.QuitClosure();
+  GURL url = net::URLRequestMockHTTPJob::GetMockHttpsUrl(
+      base::FilePath(FILE_PATH_LITERAL("empty.html")));
+  TestReporter reporter(&context_, url, callback);
+
+  EXPECT_EQ(0, network_delegate_.GetNumRequests());
+
+  reporter.SendReport(CertificateErrorReporter::REPORT_TYPE_PINNING_VIOLATION,
+                      kHostname, GetSSLInfo());
+  run_loop.Run();
+
+  EXPECT_EQ(1, network_delegate_.GetNumRequests());
+  EXPECT_EQ(url, reporter.GetLatestRequestURL());
+}
+
+// Test that pending URLRequests get cleaned up when the reporter is
+// deleted.
+TEST_F(CertificateErrorReporterTest, PendingRequestGetsDeleted) {
+  GURL url = net::URLRequestMockHTTPJob::GetMockUrlWithFailure(
+      base::FilePath(FILE_PATH_LITERAL("empty.html")),
+      net::URLRequestMockHTTPJob::START, net::ERR_IO_PENDING);
+
+  EXPECT_EQ(0, network_delegate_.GetNumRequests());
+  EXPECT_EQ(0, network_delegate_.GetNumDestroyedRequests());
+
+  TestReporter* reporter = new TestReporter(&context_, url);
+  reporter->SendReport(CertificateErrorReporter::REPORT_TYPE_PINNING_VIOLATION,
+                       kHostname, GetSSLInfo());
+  delete reporter;
+
+  EXPECT_EQ(1, network_delegate_.GetNumRequests());
+  EXPECT_EQ(1, network_delegate_.GetNumDestroyedRequests());
+}
+
+// Test that a request that returns an error gets cleaned up.
+TEST_F(CertificateErrorReporterTest, ErroredRequestGetsDeleted) {
+  GURL url = net::URLRequestFailedJob::GetMockHttpsUrl(net::ERR_FAILED);
+  base::RunLoop run_loop;
+  base::Closure callback = run_loop.QuitClosure();
+
+  EXPECT_EQ(0, network_delegate_.GetNumRequests());
+  EXPECT_EQ(0, network_delegate_.GetNumDestroyedRequests());
+
+  TestReporter reporter(&context_, url, callback);
+  reporter.SendReport(CertificateErrorReporter::REPORT_TYPE_PINNING_VIOLATION,
+                      kHostname, GetSSLInfo());
+  run_loop.Run();
+
+  EXPECT_EQ(1, network_delegate_.GetNumRequests());
+  EXPECT_EQ(1, network_delegate_.GetNumDestroyedRequests());
+}
+
+}  // namespace
+
+namespace chrome_browser_net {
+
+// Test that a built report has the correct data.
+//
+// This test is in the chrome_browser_net namespace so that it can be
+// friended by CertificateErrorReporter.
+TEST_F(CertificateErrorReporterTest, ReportIsBuiltCorrectly) {
+  SSLInfo info = GetSSLInfo();
+  CertLoggerRequest request;
+  CertificateErrorReporter::BuildReport(kHostname, info, &request);
+
+  EXPECT_EQ(request.hostname(), kHostname);
+  EXPECT_EQ(request.cert_chain(), GetPEMEncodedChain());
+  EXPECT_EQ(request.pin().size(), 1);
+  EXPECT_EQ(request.pin().Get(0), kDummyFailureLog);
+}
+}  // namespace chrome_browser_net