Index: chrome/browser/net/chrome_fraudulent_certificate_reporter.h |
diff --git a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h |
index c9874768f1e818aeccfa58e670851e2dfc4f55ed..0d73e11b0901f10b9e0119723eaba3daf1efe8ec 100644 |
--- a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h |
+++ b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h |
@@ -8,6 +8,7 @@ |
#include <set> |
#include <string> |
+#include "chrome/browser/net/certificate_error_reporter.h" |
Ryan Sleevi
2015/03/06 21:32:47
You can forward declare this class
estark
2015/03/07 00:38:50
I don't think I can, because of the scoped_ptr to
|
#include "net/url_request/fraudulent_certificate_reporter.h" |
#include "net/url_request/url_request.h" |
Ryan Sleevi
2015/03/06 21:32:47
You no longer need this include
estark
2015/03/07 00:38:50
Done.
|
@@ -18,37 +19,23 @@ class URLRequestContext; |
namespace chrome_browser_net { |
class ChromeFraudulentCertificateReporter |
- : public net::FraudulentCertificateReporter, |
- public net::URLRequest::Delegate { |
+ : public net::FraudulentCertificateReporter { |
public: |
explicit ChromeFraudulentCertificateReporter( |
net::URLRequestContext* request_context); |
- ~ChromeFraudulentCertificateReporter() override; |
+ // Useful for tests to use a mock reporter. |
+ explicit ChromeFraudulentCertificateReporter( |
+ scoped_ptr<CertificateErrorReporter> certificate_reporter); |
Ryan Sleevi
2015/03/06 21:32:47
You need to include scoped_ptr's header
estark
2015/03/07 00:38:50
Done.
|
- // Allows users of this class to override this and set their own URLRequest |
- // type. Used by SendReport. |
- virtual scoped_ptr<net::URLRequest> CreateURLRequest( |
- net::URLRequestContext* context); |
+ ~ChromeFraudulentCertificateReporter() override {} |
// net::FraudulentCertificateReporter |
void SendReport(const std::string& hostname, |
const net::SSLInfo& ssl_info) override; |
- // net::URLRequest::Delegate |
- void OnResponseStarted(net::URLRequest* request) override; |
- void OnReadCompleted(net::URLRequest* request, int bytes_read) override; |
- |
- protected: |
- net::URLRequestContext* const request_context_; |
- |
private: |
- // Performs post-report cleanup. |
- void RequestComplete(net::URLRequest* request); |
- |
- const GURL upload_url_; |
- // Owns the contained requests. |
- std::set<net::URLRequest*> inflight_requests_; |
+ scoped_ptr<CertificateErrorReporter> certificate_reporter_; |
DISALLOW_COPY_AND_ASSIGN(ChromeFraudulentCertificateReporter); |
}; |
@@ -56,4 +43,3 @@ class ChromeFraudulentCertificateReporter |
} // namespace chrome_browser_net |
#endif // CHROME_BROWSER_NET_CHROME_FRAUDULENT_CERTIFICATE_REPORTER_H_ |
- |