Refactor ChromeFraudulentCertReporter for code reuse by SSL reporting

chrome/browser/net/certificate_error_reporter.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
+#define CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
+
+#include <set>
+#include <string>
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "net/url_request/url_request.h"
+#include "url/gurl.h"
+
+namespace net {
+class URLRequestContext;
+class SSLInfo;
+}
+
+namespace chrome_browser_net {
+
+class CertLoggerRequest;
+
+// Provides functionality for sending reports about invalid SSL
+// certificate chains to a report collection server.
+class CertificateErrorReporter : public net::URLRequest::Delegate {
+ public:
+  enum ReportType {
+    REPORT_TYPE_PINNING_VIOLATION,
+    REPORT_TYPE_EXTENDED_REPORTING
+  };

[Ryan Sleevi, 2015/03/12 05:15:05]

Enhance. Enhance.


(With documentation)

[estark, 2015/03/12 14:21:48]

Done.

+
+  CertificateErrorReporter(net::URLRequestContext* request_context,

[Ryan Sleevi, 2015/03/12 05:15:05]

Document

// Create a certificate error reporter that will send certificate error reports
to |upload_url|,
// using |request_context| as the context for such reports.

(Or something; Matt or Adrienne can probably word something less awkward)

[estark, 2015/03/12 14:21:48]

Done.

+                           const GURL& upload_url);
+
+  ~CertificateErrorReporter() override;
+
+  // Construct, serialize, and send a certificate reporter to the report
+  // collection server containing the |ssl_info| associated with a
+  // connection to |hostname|.
+  virtual void SendReport(ReportType type,
+                          const std::string& hostname,
+                          const net::SSLInfo& ssl_info);
+
+  // net::URLRequest::Delegate
+  void OnResponseStarted(net::URLRequest* request) override;
+  void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
+
+ private:
+  // Create a URLRequest with which to send a certificate report to the
+  // server.
+  virtual scoped_ptr<net::URLRequest> CreateURLRequest(
+      net::URLRequestContext* context);
+
+  // Serialize and send a CertLoggerRequest protobuf to the report
+  // collection server.
+  void SendCertLoggerRequest(const CertLoggerRequest& request);
+
+  // Populate the CertLoggerRequest for a report.
+  static void BuildReport(const std::string& hostname,
+                          const net::SSLInfo& ssl_info,
+                          CertLoggerRequest* out_request);
+
+  // Performs post-report cleanup.
+  void RequestComplete(net::URLRequest* request);
+
+  net::URLRequestContext* const request_context_;
+  const GURL upload_url_;
+
+  // Owns the contained requests.
+  std::set<net::URLRequest*> inflight_requests_;
+
+  DISALLOW_COPY_AND_ASSIGN(CertificateErrorReporter);
+};
+
+}  // namespace chrome_browser_net
+
+#endif  // CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_