Refactor ChromeFraudulentCertReporter for code reuse by SSL reporting

chrome/browser/net/certificate_error_reporter.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
+#define CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_
+
+#include <set>
+#include <string>
+
+#include "base/gtest_prod_util.h"
+#include "net/url_request/url_request.h"
+
+namespace net {
+class URLRequestContext;
+}
+
+namespace chrome_browser_net {
+
+class CertLoggerRequest;
+
+// Provides functionality for sending reports about invalid SSL
+// certificate chains to a report collection server.
+class CertificateErrorReporter : public net::URLRequest::Delegate {
+ public:
+  enum ReportType {
+    REPORT_TYPE_PINNING_VIOLATION,
+    REPORT_TYPE_EXTENDED_REPORTING
+  };
+
+  CertificateErrorReporter(net::URLRequestContext* request_context,
+                           const GURL& upload_url);

[Ryan Sleevi, 2015/03/09 22:14:06]

Missing include for "url/gurl.h" ( needed because line 70 has it as a member)

[estark, 2015/03/09 23:21:17]

Done. Is there a tool that you use to catch these or just by looking at it?

[Ryan Sleevi, 2015/03/09 23:44:56]

Just by looking. There used to be Include What You Use (IWYU), but that's
largely orphaned / doesn't work well on the Chrome codebase.

+
+  ~CertificateErrorReporter() override;
+
+  // Construct, serialize, and send a certificate reporter to the report
+  // collection server containing the |ssl_info| associated with a
+  // connection to |hostname|.
+  virtual void SendReport(ReportType type,
+                          const std::string& hostname,
+                          const net::SSLInfo& ssl_info);

[Ryan Sleevi, 2015/03/09 22:14:06]

Missing forward declaration of SSLInfo

[estark, 2015/03/09 23:21:17]

Done.

+
+  // net::URLRequest::Delegate
+  void OnResponseStarted(net::URLRequest* request) override;
+  void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
+
+ private:
+  // Allow tests to access private data members.
+  FRIEND_TEST_ALL_PREFIXES(CertificateErrorReporterTest,
+                           ReportIsBuiltCorrectly);
+
+  // Create a URLRequest with which to send a certificate report to the
+  // server.
+  virtual scoped_ptr<net::URLRequest> CreateURLRequest(

[Ryan Sleevi, 2015/03/09 22:14:06]

Missing include of scoped_ptr

(As you fix all these, make sure to update the .cc to either not include what's
in the .h or include what's forward declared)

[estark, 2015/03/09 23:21:17]

Done.

+      net::URLRequestContext* context);
+
+  // Serialize and send a CertLoggerRequest protobuf to the report
+  // collection server.
+  void SendCertLoggerRequest(CertLoggerRequest& request);

[Ryan Sleevi, 2015/03/09 22:14:06]

STYLE: Not allowed to pass non-const references -
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Reference_Arg...

[estark, 2015/03/09 23:21:16]

Done.

+
+  // Populate the CertLoggerRequest for a report.
+  static void BuildReport(const std::string& hostname,
+                          const net::SSLInfo& ssl_info,
+                          CertLoggerRequest& out_request);

[Ryan Sleevi, 2015/03/09 22:14:06]

STYLE: Not allowed to pass non-const references
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Reference_Arg...

[estark, 2015/03/09 23:21:17]

Done.

+
+  // Performs post-report cleanup.
+  void RequestComplete(net::URLRequest* request);
+
+  net::URLRequestContext* const request_context_;
+  const GURL upload_url_;
+
+  // Owns the contained requests.
+  std::set<net::URLRequest*> inflight_requests_;
+
+  DISALLOW_COPY_AND_ASSIGN(CertificateErrorReporter);
+};
+
+}  // namespace chrome_browser_net
+
+#endif  // CHROME_BROWSER_NET_CERTIFICATE_ERROR_REPORTER_H_