Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 979833003: Fix flaky TabListBackendTest (Closed)

Created:
5 years, 9 months ago by Zhen Wang
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky TabListBackendTest The tests should only run when tab control is supported. See log on FYI bot Android Tests (K N5, user build)(dbg): http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28K%20N5%2C%20user%20build%29%28dbg%29/builds/3050/steps/telemetry_unittests/logs/stdio BUG=437881 Committed: https://crrev.com/fcfd80de79aa6bf4344be9e611ff988a6312a1f3 Cr-Commit-Position: refs/heads/master@{#319103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/tab_list_backend_unittest.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Zhen Wang
ptal
5 years, 9 months ago (2015-03-04 16:53:45 UTC) #2
sullivan
lgtm (stealing this since Ned is super busy this week)
5 years, 9 months ago (2015-03-04 16:56:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979833003/1
5 years, 9 months ago (2015-03-04 17:19:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/2065) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-04 17:28:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979833003/1
5 years, 9 months ago (2015-03-04 19:14:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 19:44:35 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 19:45:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcfd80de79aa6bf4344be9e611ff988a6312a1f3
Cr-Commit-Position: refs/heads/master@{#319103}

Powered by Google App Engine
This is Rietveld 408576698