Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Unified Diff: Source/core/html/HTMLPlugInElement.cpp

Issue 979833002: Remove check from HTMLPlugInElement::requestObject (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLPlugInElement.cpp
diff --git a/Source/core/html/HTMLPlugInElement.cpp b/Source/core/html/HTMLPlugInElement.cpp
index 8bdde345283af03b7b29bf6a24f48181f1ac4c7f..d5c5fc4cf7211ce48d61675c4d99e0483c173864 100644
--- a/Source/core/html/HTMLPlugInElement.cpp
+++ b/Source/core/html/HTMLPlugInElement.cpp
@@ -501,20 +501,13 @@ bool HTMLPlugInElement::requestObject(const String& url, const String& mimeType,
if (protocolIsJavaScript(url))
return false;
- // FIXME: None of this code should use renderers!
- LayoutEmbeddedObject* renderer = layoutEmbeddedObject();
- ASSERT(renderer);
- if (!renderer)
- return false;
-
KURL completedURL = document().completeURL(url);
if (!pluginIsLoadable(completedURL, mimeType))
return false;
bool useFallback;
- bool requireRenderer = true;
if (shouldUsePlugin(completedURL, mimeType, hasFallbackContent(), useFallback))
- return loadPlugin(completedURL, mimeType, paramNames, paramValues, useFallback, requireRenderer);
+ return loadPlugin(completedURL, mimeType, paramNames, paramValues, useFallback, true);
// If the plug-in element already contains a subframe,
// loadOrRedirectSubframe will re-use it. Otherwise, it will create a new
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698