Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 979833002: Remove check from HTMLPlugInElement::requestObject (Closed)

Created:
5 years, 9 months ago by rwlbuis
Modified:
5 years, 9 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove check from HTMLPlugInElement::requestObject Remove check from HTMLPlugInElement::requestObject since the callsites already check that the renderer exists. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191303

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M Source/core/html/HTMLPlugInElement.cpp View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rwlbuis
PTAL
5 years, 9 months ago (2015-03-04 17:11:29 UTC) #2
Nate Chapin
LGTM https://codereview.chromium.org/979833002/diff/1/Source/core/html/HTMLPlugInElement.cpp File Source/core/html/HTMLPlugInElement.cpp (right): https://codereview.chromium.org/979833002/diff/1/Source/core/html/HTMLPlugInElement.cpp#newcode509 Source/core/html/HTMLPlugInElement.cpp:509: bool requireRenderer = true; While we're here, inline ...
5 years, 9 months ago (2015-03-04 17:36:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979833002/20001
5 years, 9 months ago (2015-03-04 18:15:33 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 20:00:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191303

Powered by Google App Engine
This is Rietveld 408576698