Issue 97983003: Start the move of launcher_types.h to shelf.

Issue 97983003: Start the move of launcher_types.h to shelf. (Closed)

Created:
7 years ago by tfarina

Modified:
6 years, 12 months ago

Reviewers:
Harry McCleave, James Cook

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Start the move of launcher_types.h to shelf. I decided to split the constants into its own component to make the transition easier to do and review. BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org TBR=tapted@chromium.org # for c/b/ui/apps Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242588

Patch Set 1 #

Patch Set 2 : the rename #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -47 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/ash_export.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/launcher/launcher_types.h	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	ash/launcher/launcher_types.cc	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download
M	ash/shelf/app_list_button.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/shelf/overflow_bubble_view.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
A	ash/shelf/shelf_constants.h	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A	ash/shelf/shelf_constants.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	ash/shelf/shelf_layout_manager.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/shelf/shelf_layout_manager.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/shelf/shelf_util.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/shelf/shelf_view.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/shelf/shelf_view_unittest.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/shelf/shelf_widget.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	ash/shelf/shelf_window_watcher.cc	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	ash/wm/dock/docked_window_layout_manager.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/apps/chrome_shell_window_delegate.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc	View	1	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Cook

LGTM. I like it! Feel free to commit it -- Harry is on vacation.

6 years, 12 months ago (2013-12-26 18:36:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/97983003/30001

6 years, 12 months ago (2013-12-26 23:33:38 UTC) #3

Message was sent while issue was closed.

Change committed as 242588

Expand Messages | Collapse Messages