Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 979823004: Unit tests for misspelled policy names. (Closed)

Created:
5 years, 9 months ago by Łukasz Anforowicz
Modified:
5 years, 9 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unit tests for misspelled policy names. This verifies that we detect and report misspelled policy names regardless of whether "RemoteAccessHost" appears as a prefix, suffix or a substring. I felt adding this test is important to "document" the behavior asked about in https://codereview.chromium.org/966433002/diff/120001/remoting/host/policy_watcher.cc#newcode109 The new test verifies expected behavior via MockLog class moved to base/test in crrev.com/966423003. I feel that the benefit of documenting and automatically verifying the expected behavior outweights the small maintenence cost of an additional test and the slight ickyness of verifying the behavior by looking at log output. BUG= Committed: https://crrev.com/bfe7577b0faa92b2fc912b7bbfe85bd994ac7e33 Cr-Commit-Position: refs/heads/master@{#319172}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M remoting/host/policy_watcher_unittest.cc View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Łukasz Anforowicz
Renato, could you please take a look?
5 years, 9 months ago (2015-03-04 22:11:36 UTC) #3
rmsousa
lgtm
5 years, 9 months ago (2015-03-04 23:32:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979823004/20001
5 years, 9 months ago (2015-03-04 23:55:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-05 00:28:20 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 00:29:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfe7577b0faa92b2fc912b7bbfe85bd994ac7e33
Cr-Commit-Position: refs/heads/master@{#319172}

Powered by Google App Engine
This is Rietveld 408576698