Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: runtime/observatory/lib/src/app/application.dart

Issue 979823003: Major rework of vm service events. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/application.dart
diff --git a/runtime/observatory/lib/src/app/application.dart b/runtime/observatory/lib/src/app/application.dart
index c5413c9dd03b5a44a7f38572db10126b725bb5e8..c3c49e4e9fa4f23fc127ec1f8d8acf74e2203bb8 100644
--- a/runtime/observatory/lib/src/app/application.dart
+++ b/runtime/observatory/lib/src/app/application.dart
@@ -64,46 +64,29 @@ class ObservatoryApplication extends Observable {
void _onEvent(ServiceEvent event) {
switch(event.eventType) {
- case 'IsolateCreated':
+ case 'IsolateStart':
+ case '_Graph':
+ case 'BreakpointAdded':
+ case 'BreakpointResolved':
+ case 'BreakpointRemoved':
+ case 'GC':
// Ignore for now.
break;
- case 'IsolateResumed':
- event.isolate.pauseEvent = null;
- break;
-
- case 'IsolateShutdown':
- // TODO(turnidge): Should we show the user isolate shutdown events?
- // What if there are hundreds of them? Coalesce multiple
- // shutdown events into one notification?
+ case 'IsolateExit':
+ case 'Resume':
removePauseEvents(event.isolate);
-
- // TODO(turnidge): Reload the isolate for now in case it is
- // paused. We may need to distinguish an IsolateShutdown
- // event from a "paused at isolate shutdown" event.
- event.isolate.reload();
break;
- case 'BreakpointResolved':
- event.isolate.reloadBreakpoints();
- break;
-
- case 'BreakpointReached':
- case 'IsolateInterrupted':
- case 'ExceptionThrown':
- event.isolate.pauseEvent = event;
+ case 'PauseStart':
+ case 'PauseExit':
+ case 'PauseBreakpoint':
+ case 'PauseInterrupted':
+ case 'PauseException':
removePauseEvents(event.isolate);
notifications.add(event);
break;
- case '_Graph':
- event.isolate.loadHeapSnapshot(event);
- break;
-
- case 'GC':
- // Ignore GC events for now.
- break;
-
default:
// Ignore unrecognized events.
Logger.root.severe('Unrecognized event: $event');
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/debugger.dart » ('j') | runtime/observatory/lib/src/elements/debugger.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698