Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 979823002: [turbofan] Enable DeoptFinallyReturn test that no longer fails. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Enable DeoptFinallyReturn test that no longer fails. This was fixed by 064be2385ad3 and will no longer fail, even on the no-snap ARM64 simulator. R=bmeurer@chromium.org TEST=cctest/test-run-jsexceptions/DeoptFinallyReturn Committed: https://crrev.com/23fb4eb8f3973fd643efc6d056857ffdf8241f2b Cr-Commit-Position: refs/heads/master@{#27005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M test/cctest/compiler/test-run-jsexceptions.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-04 14:55:26 UTC) #1
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-04 18:22:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979823002/1
5 years, 9 months ago (2015-03-05 08:51:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 09:17:07 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 09:17:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23fb4eb8f3973fd643efc6d056857ffdf8241f2b
Cr-Commit-Position: refs/heads/master@{#27005}

Powered by Google App Engine
This is Rietveld 408576698