Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 979783002: Respect accumulative old generation memory limit in all spaces. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Respect accumulative old generation memory limit in all spaces. Before the max_old_space_size was set for each space, which is not intuitive and not what we want. There is still a miss match between capacity and actual committed memory which should be cleaned up in a follow up cl. BUG= Committed: https://crrev.com/bd89a2eb617422bfbd0690d26468ae2f02584565 Cr-Commit-Position: refs/heads/master@{#26985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M src/heap/heap.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
lgtm
5 years, 9 months ago (2015-03-04 13:19:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979783002/1
5 years, 9 months ago (2015-03-04 13:41:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 13:43:29 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 13:43:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd89a2eb617422bfbd0690d26468ae2f02584565
Cr-Commit-Position: refs/heads/master@{#26985}

Powered by Google App Engine
This is Rietveld 408576698