Issue 979743002: Bugfixes in CPS RecursiveVisitor and ParentVisitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 979743002: Bugfixes in CPS RecursiveVisitor and ParentVisitor. (Closed)

Created:
5 years, 9 months ago by asgerf

Modified:
5 years, 9 months ago

Reviewers:
karlklose, Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Bugfixes in CPS RecursiveVisitor and ParentVisitor. - ParentVisitor should not skip over RunnableBodies nodes. - RecursiveVisitor should not skip over RunnableBody nodes. - Process variable reference in GetMutableVariable. BUG=

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

On 2015/03/04 10:37:59, kmillikin wrote: > LGTM. Seems to be subsumed by https://codereview.chromium.org/979693003/ so I'll ...

5 years, 9 months ago (2015-03-04 11:49:20 UTC) #6

Kevin Millikin (Google)

5 years, 9 months ago (2015-03-04 11:52:41 UTC) #7

Message was sent while issue was closed.

On 2015/03/04 11:49:20, asgerf wrote:
> On 2015/03/04 10:37:59, kmillikin wrote:
> > LGTM.
> 
> Seems to be subsumed by https://codereview.chromium.org/979693003/ so I'll
close
> this again.

Actually I merged this change into that one because they were necessary to make
all the tests pass....  :)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages