Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 979723002: Revert of Two small bugfixes (Closed)

Created:
5 years, 9 months ago by Finnur
Modified:
5 years, 9 months ago
Reviewers:
rkc, Charlie
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Two small bugfixes (patchset #3 id:60001 of https://codereview.chromium.org/969843002/) Reason for revert: Causes test to consistently time out. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35869 [ RUN ] ChromeWhispernetClientTest.EncodeAndDecode [724:3320:0303/204246:WARNING:data_reduction_proxy_config.cc(240)] SPDY proxy OFF at startup [3956:4296:0303/204248:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread! [724:4156:0303/204249:INFO:CONSOLE(5)] "Not allowed to load local resource: chrome://resources/css/text_defaults.css", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/background.html (5) [724:4156:0303/204249:INFO:CONSOLE(83)] "init: Starting Nacl bridge.", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (83) [2012:2524:0303/204249:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread! [2012:2832:0303/204249:ERROR:pnacl_translation_resource_host.cc(135)] Got invalid platformfilefortransit [724:4156:0303/204253:INFO:CONSOLE(65)] "init: Nacl ready!", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (65) [724:4156:0303/204254:INFO:CONSOLE(26)] "Configuring encoder and decoder for client E77A9C58-00C9-4A99-AC57-1353FB0B918D", source: chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (26) [223/223] ChromeWhispernetClientTest.EncodeAndDecode (TIMED OUT) Original issue's description: > 1. Token CRCs are not handled correctly. This adds the corrected Whispernet binary (from cl/87383487), and a test to confirm the correct behavior. > > 2. If we get tokens that require more than one padding character, the padding will not be completely removed when appropriate. This is a simple change in the js. > > BUG=463218 > > Committed: https://crrev.com/6e37f17aa09f5244315d6eb84fa305154bc65062 > Cr-Commit-Position: refs/heads/master@{#319015} TBR=rkc@chromium.org,ckehoe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463218 Committed: https://crrev.com/87bd8b465b5de163a9e8583f8619b7602c4dd889 Cr-Commit-Position: refs/heads/master@{#319032}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -33 lines) Patch
M chrome/browser/copresence/chrome_whispernet_client_browsertest.cc View 7 chunks +14 lines, -31 lines 0 comments Download
M chrome/browser/resources/whispernet_proxy/js/nacl.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/whispernet_proxy/js/wrapper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/whispernet_proxy/whispernet_proxy.nmf.png View Binary file 0 comments Download
M chrome/browser/resources/whispernet_proxy/whispernet_proxy_pnacl.pexe.png View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
Finnur
Created Revert of Two small bugfixes
5 years, 9 months ago (2015-03-04 08:35:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979723002/1
5 years, 9 months ago (2015-03-04 08:35:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 08:36:12 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 08:36:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87bd8b465b5de163a9e8583f8619b7602c4dd889
Cr-Commit-Position: refs/heads/master@{#319032}

Powered by Google App Engine
This is Rietveld 408576698