pkg/compiler/lib/src/js_backend/codegen/task.dart - Issue 979693003: Streamline the CPS IR Visitor interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/task.dart

Issue 979693003: Streamline the CPS IR Visitor interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Signal an error in visit methods that should not be called. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/codegen/task.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/task.dart b/pkg/compiler/lib/src/js_backend/codegen/task.dart

index 0eb0685af40530a0cee628cb9c373567f1c9c904..10c5d514cb823dd0859d49ecd85d1af7a73b2613 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/task.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/task.dart

@@ -164,7 +164,7 @@ class CpsFunctionCompiler implements FunctionCompiler {

// Do not rewrite the IR after variable allocation. Allocation

// makes decisions based on an approximation of IR variable live

// ranges that can be invalidated by transforming the IR.

- new cps.RegisterAllocator().visit(cpsNode);

+ new cps.RegisterAllocator(compiler.internalError).visit(cpsNode);

return cpsNode;

}