Issue 979693002: Specify inputs and testonly in Go GN rules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 979693002: Specify inputs and testonly in Go GN rules (Closed)

Created:
5 years, 9 months ago by jamesr

Modified:
5 years, 9 months ago

Reviewers:
rogulenko

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Specify inputs and testonly in Go GN rules This marks the go_test_binary targets as testonly so they can depend on other testonly things, such as the test mojom targets, and marks the sources to the go rules as 'inputs' to the GN action so that ninja knows to rerun the go step when a go file specified as a source changes. This does not handle changes to things that the go tool finds to import (for that we'll need a script that generates a .d file) but simplifies the common workflow so is probably worth having in the meantime. R=rogulenko@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c95ed8bb282b249a9f11286813192aff4efe2a5f

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	mojo/go/rules.gni	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

The "inputs" thing is a stopgap, but I think it's pretty useful for now.

5 years, 9 months ago (2015-03-04 06:15:26 UTC) #1

jamesr

5 years, 9 months ago (2015-03-04 22:13:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c95ed8bb282b249a9f11286813192aff4efe2a5f (presubmit successful).

Expand Messages | Collapse Messages