Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 979643002: Fix the following browser_tests in the Linux GN build. (Closed)

Created:
5 years, 9 months ago by jam
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the following browser_tests in the Linux GN build. The test method to find the generated protobuf python files needed to be updated. Also I copied a bunch of test files to the product dir. DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.ApiAuthCodeFetch/1 DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.AutoEnrollment/1 DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.PolicyFetch/1 DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.Registration/1 DeviceManagementServiceIntegrationTestInstance/DeviceManagementServiceIntegrationTest.Unregistration/1 ComponentCloudPolicyTest.FetchExtensionPolicy ComponentCloudPolicyTest.InstallNewExtension ComponentCloudPolicyTest.SignOutAndBackIn ComponentCloudPolicyTest.UpdateExtensionPolicy CloudPolicyTest.FetchoPlicy CloudPolicyTest.InvalidatePolicy BUG=463180 Committed: https://crrev.com/b533b7efedd6a6e17dd98fc0c0ad5a4fac4a1fb2 Cr-Commit-Position: refs/heads/master@{#319075}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -20 lines) Patch
M chrome/browser_tests.isolate View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M net/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M net/test/python_utils.cc View 2 chunks +21 lines, -16 lines 0 comments Download
M ppapi/BUILD.gn View 2 chunks +26 lines, -0 lines 0 comments Download
M third_party/protobuf/BUILD.gn View 1 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jam
5 years, 9 months ago (2015-03-04 01:52:49 UTC) #2
brettw
LGTM with these and the Android fixes. https://codereview.chromium.org/979643002/diff/1/chrome/browser_tests.isolate File chrome/browser_tests.isolate (right): https://codereview.chromium.org/979643002/diff/1/chrome/browser_tests.isolate#newcode63 chrome/browser_tests.isolate:63: #'<PRODUCT_DIR)/gen/google/', Reference ...
5 years, 9 months ago (2015-03-04 02:46:47 UTC) #3
jam
https://codereview.chromium.org/979643002/diff/1/chrome/browser_tests.isolate File chrome/browser_tests.isolate (right): https://codereview.chromium.org/979643002/diff/1/chrome/browser_tests.isolate#newcode63 chrome/browser_tests.isolate:63: #'<PRODUCT_DIR)/gen/google/', On 2015/03/04 02:46:47, brettw wrote: > Reference <(SHARED_INTERMEDIATE_DIR)/google ...
5 years, 9 months ago (2015-03-04 15:17:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979643002/20001
5 years, 9 months ago (2015-03-04 15:18:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 17:12:16 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 17:13:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b533b7efedd6a6e17dd98fc0c0ad5a4fac4a1fb2
Cr-Commit-Position: refs/heads/master@{#319075}

Powered by Google App Engine
This is Rietveld 408576698