Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(61)

Issue 979633002: ARM assembler: fix undefined behaviour in fits_shifter (Closed)

Created:
4 years, 6 months ago by hans
Modified:
4 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM assembler: fix undefined behaviour in fits_shifter Bit-shifts have undefined behaviour if the shift amount is greater or equal to the width of the type. In this case the code would do imm32 >> 32 when rot == 0. A newer version of Clang unrolled the loop, optimized the first iteration away, causing the test suite to fail with: # # Fatal error in ../src/arm/assembler-arm.cc, line 1212 # Check failed: !rn.is(ip). # as well as crashing when running Chromium tests on Android (at least we think this was the cause, see the bug). BUG=463436, 444089 LOG=Y Committed: https://crrev.com/721fdb56e0fc92c662c7d8b42be8a1d689c3b535 Cr-Commit-Position: refs/heads/master@{#26974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/arm/assembler-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
hans
This is blocking the Clang roll. It would be great if someone could review this, ...
4 years, 6 months ago (2015-03-04 00:46:08 UTC) #2
Erik Corry
LGTM
4 years, 6 months ago (2015-03-04 01:21:09 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2015-03-04 01:21:41 UTC) #5
Nico
On 2015/03/04 01:21:41, jochen (traveling) wrote: > lgtm Can someone land?
4 years, 6 months ago (2015-03-04 01:31:24 UTC) #6
jochen (gone - plz use gerrit)
On 2015/03/04 at 01:31:24, thakis wrote: > On 2015/03/04 01:21:41, jochen (traveling) wrote: > > ...
4 years, 6 months ago (2015-03-04 01:32:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979633002/1
4 years, 6 months ago (2015-03-04 01:32:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2015-03-04 03:13:36 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/721fdb56e0fc92c662c7d8b42be8a1d689c3b535 Cr-Commit-Position: refs/heads/master@{#26974}
4 years, 6 months ago (2015-03-04 03:13:47 UTC) #11
hans
Thanks! Who can help getting this merged to and rolled into Chromium?
4 years, 6 months ago (2015-03-04 03:25:19 UTC) #12
jochen (gone - plz use gerrit)
4 years, 6 months ago (2015-03-04 03:39:11 UTC) #13
Message was sent while issue was closed.
On 2015/03/04 at 03:25:19, hans wrote:
> Thanks!
> 
> Who can help getting this merged to and rolled into Chromium?

It should auto-roll

Powered by Google App Engine
This is Rietveld 408576698