Issue 97963002: events: Remove KeyEvent::Copy().

Issue 97963002: events: Remove KeyEvent::Copy(). (Closed)

Created:
7 years ago by sadrul

Modified:
7 years ago

Reviewers:
sky, Evan Stade

CC:
chromium-reviews, oshima+watch_chromium.org, yukishiino+watch_chromium.org, benquan, tfarina, stevenjb+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, kalyank, James Su, Ilya Sherman, ben+ash_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

events: Remove KeyEvent::Copy(). It is possible to copy a key-event using the copy-constructor, without needing a separate method for it. So remove the redundant code for copying a KeyEvent. BUG=none R=estade@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238205

Patch Set 1 #

Patch Set 2 : fix-win #

Total comments: 2

Patch Set 3 : . #

Total comments: 2

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -29 lines)			Patch
M	ash/wm/sticky_keys.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/sticky_keys_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_dialog_views.cc	View	1 2	1 chunk	+3 lines, -3 lines	2 comments	Download
M	content/browser/renderer_host/native_web_keyboard_event_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/ime/chromeos/mock_ime_engine_handler.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/ime/input_method_ibus.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/events/event.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/events/event.cc	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	ui/events/event_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_win.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

https://codereview.chromium.org/97963002/diff/20001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/97963002/diff/20001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode1697 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:1697: scoped_ptr<ui::KeyEvent> copy(new ui::KeyEvent(key_event)); no need to make this a ...

7 years ago (2013-12-02 18:17:32 UTC) #2

sadrul

7 years ago (2013-12-02 18:29:58 UTC) #3

Evan Stade

autofill lgtm https://codereview.chromium.org/97963002/diff/60001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/97963002/diff/60001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode1698 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:1698: #if defined(OS_WIN) && !defined(USE_AURA) Q: when can ...

7 years ago (2013-12-02 19:16:39 UTC) #4

sadrul

https://codereview.chromium.org/97963002/diff/60001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://codereview.chromium.org/97963002/diff/60001/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode1698 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:1698: #if defined(OS_WIN) && !defined(USE_AURA) On 2013/12/02 19:16:39, Evan Stade ...

7 years ago (2013-12-02 19:21:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r238205 (presubmit successful).

Expand Messages | Collapse Messages