Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 979573002: [Telemetry] Un-break help command (Closed)

Created:
5 years, 9 months ago by eakuefner
Modified:
5 years, 9 months ago
Reviewers:
nednguyen, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Un-break help command This CL fixes the help command of benchmark_runner, which broke after the local environment switch. R=dtu,nednguyen Committed: https://crrev.com/3a0ea5d0230c75a71efe04e1e59b4719d47e014f Cr-Commit-Position: refs/heads/master@{#318976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/benchmark_runner.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
eakuefner
I'm going to add benchmark_runner_unittest to extensively test that the commands aren't broken, but since ...
5 years, 9 months ago (2015-03-03 22:37:32 UTC) #1
dtu
lgtm
5 years, 9 months ago (2015-03-03 22:39:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979573002/1
5 years, 9 months ago (2015-03-03 22:40:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 00:22:55 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 00:23:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a0ea5d0230c75a71efe04e1e59b4719d47e014f
Cr-Commit-Position: refs/heads/master@{#318976}

Powered by Google App Engine
This is Rietveld 408576698