Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 979483002: [Chromoting] Remove hangout consent dialog. (Closed)

Created:
5 years, 9 months ago by garykac
Modified:
5 years, 9 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Remove hangout consent dialog. We're updating our build to ensure that all html files are auto generated and jscompiled. This html file is being removed now (rather than updated to be jscompiled) because we intend to remove the It2MeHelpeeChannel code in the near future. BUG= Committed: https://crrev.com/2f51134af40b596569eb0542727db995e6b07369 Cr-Commit-Position: refs/heads/master@{#318992}

Patch Set 1 #

Patch Set 2 : Fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -323 lines) Patch
M remoting/remoting_webapp_files.gypi View 3 chunks +0 lines, -5 lines 0 comments Download
D remoting/webapp/crd/html/dialog_hangout_consent.css View 1 chunk +0 lines, -103 lines 0 comments Download
D remoting/webapp/crd/html/dialog_hangout_consent.html View 1 chunk +0 lines, -36 lines 0 comments Download
D remoting/webapp/crd/js/hangout_consent_dialog.js View 1 chunk +0 lines, -105 lines 0 comments Download
D remoting/webapp/crd/js/hangout_consent_dialog_main.js View 1 chunk +0 lines, -63 lines 0 comments Download
M remoting/webapp/crd/js/it2me_helpee_channel.js View 1 chunk +1 line, -6 lines 0 comments Download
M remoting/webapp/unittests/it2me_helpee_channel_unittest.js View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
garykac
5 years, 9 months ago (2015-03-03 19:56:26 UTC) #2
kelvinp
lgtm
5 years, 9 months ago (2015-03-03 21:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979483002/20001
5 years, 9 months ago (2015-03-03 21:50:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 01:29:35 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 01:30:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f51134af40b596569eb0542727db995e6b07369
Cr-Commit-Position: refs/heads/master@{#318992}

Powered by Google App Engine
This is Rietveld 408576698