Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 979463002: Use updated WebMediaKeySystemConfiguration (Closed)

Created:
5 years, 9 months ago by jrummell
Modified:
5 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use updated WebMediaKeySystemConfiguration WebMediaKeySystemConfiguration is changing to use enums for initDataTypes and sessionTypes, so update WebEncryptedMediaClientImpl to use the enums. BUG=418239 TEST=EME tests still pass Committed: https://crrev.com/606a1097ae876cde715129bebeec5efa489cbeee Cr-Commit-Position: refs/heads/master@{#319145}

Patch Set 1 #

Total comments: 3

Patch Set 2 : remove notreached string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M media/blink/webencryptedmediaclient_impl.cc View 1 4 chunks +35 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jrummell
PTAL. https://codereview.chromium.org/979463002/diff/1/media/blink/webencryptedmediaclient_impl.cc File media/blink/webencryptedmediaclient_impl.cc (right): https://codereview.chromium.org/979463002/diff/1/media/blink/webencryptedmediaclient_impl.cc#newcode158 media/blink/webencryptedmediaclient_impl.cc:158: // 2.2.2. If initDataType is the empty string, ...
5 years, 9 months ago (2015-03-03 19:10:48 UTC) #2
sandersd (OOO until July 31)
lgtm https://codereview.chromium.org/979463002/diff/1/media/blink/webencryptedmediaclient_impl.cc File media/blink/webencryptedmediaclient_impl.cc (right): https://codereview.chromium.org/979463002/diff/1/media/blink/webencryptedmediaclient_impl.cc#newcode178 media/blink/webencryptedmediaclient_impl.cc:178: NOTREACHED() << "unexpected init_data_type"; Remove message text.
5 years, 9 months ago (2015-03-03 19:46:08 UTC) #3
jrummell
Thanks for the review. https://codereview.chromium.org/979463002/diff/1/media/blink/webencryptedmediaclient_impl.cc File media/blink/webencryptedmediaclient_impl.cc (right): https://codereview.chromium.org/979463002/diff/1/media/blink/webencryptedmediaclient_impl.cc#newcode178 media/blink/webencryptedmediaclient_impl.cc:178: NOTREACHED() << "unexpected init_data_type"; On ...
5 years, 9 months ago (2015-03-03 21:18:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/979463002/20001
5 years, 9 months ago (2015-03-04 21:38:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-04 22:40:56 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 22:41:37 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/606a1097ae876cde715129bebeec5efa489cbeee
Cr-Commit-Position: refs/heads/master@{#319145}

Powered by Google App Engine
This is Rietveld 408576698