Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 979453002: [Extensions] Make chrome://extensions use developerPrivate for unpacked loading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/unpacked_installer.cc
diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc
index b4f3976ae77c295088af8b0e713588c641efd47a..36368aca93b1c68fb52ecd1cb8c311840d5f9fb5 100644
--- a/chrome/browser/extensions/unpacked_installer.cc
+++ b/chrome/browser/extensions/unpacked_installer.cc
@@ -350,6 +350,11 @@ void UnpackedInstaller::ReportExtensionLoadError(const std::string &error) {
service_weak_->profile(),
be_noisy_on_failure_);
}
+
+ if (!callback_.is_null()) {
+ callback_.Run(nullptr, extension_path_, error);
+ callback_.Reset();
+ }
}
void UnpackedInstaller::InstallExtension() {
@@ -361,6 +366,11 @@ void UnpackedInstaller::InstallExtension() {
service_weak_->OnExtensionInstalled(
extension(), syncer::StringOrdinal(), kInstallFlagInstallImmediately);
+
+ if (!callback_.is_null()) {
+ callback_.Run(extension(), extension_path_, std::string());
+ callback_.Reset();
+ }
}
} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/unpacked_installer.h ('k') | chrome/browser/resources/extensions/extension_loader.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698