content/renderer/accessibility/renderer_accessibility_browsertest.cc - Issue 979443002: PlzNavigate: send history params at commit time to the renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/renderer_accessibility_browsertest.cc

Issue 979443002: PlzNavigate: send history params at commit time to the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/accessibility/renderer_accessibility_browsertest.cc

diff --git a/content/renderer/accessibility/renderer_accessibility_browsertest.cc b/content/renderer/accessibility/renderer_accessibility_browsertest.cc

index 3af748801a9141f90ff0b3ef3f5fd8ca27fb9a0f..4a6f5570889c2e63bf04c85337788deefcf2ae3f 100644

--- a/content/renderer/accessibility/renderer_accessibility_browsertest.cc

+++ b/content/renderer/accessibility/renderer_accessibility_browsertest.cc

@@ -193,10 +193,10 @@ TEST_F(RendererAccessibilityTest,

nav_params.common_params.url = GURL("data:text/html,<p>Hello, again.</p>");

nav_params.common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;

nav_params.common_params.transition = ui::PAGE_TRANSITION_TYPED;

- nav_params.current_history_list_length = 1;

- nav_params.current_history_list_offset = 0;

- nav_params.pending_history_list_offset = 1;

- nav_params.page_id = -1;

+ nav_params.history_params.current_history_list_length = 1;

+ nav_params.history_params.current_history_list_offset = 0;

+ nav_params.history_params.pending_history_list_offset = 1;

+ nav_params.history_params.page_id = -1;

nav_params.commit_params.browser_navigation_start =

base::TimeTicks::FromInternalValue(1);

frame()->OnNavigate(nav_params);

« no previous file with comments | « content/public/test/render_view_test.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »