content/public/test/render_view_test.cc - Issue 979443002: PlzNavigate: send history params at commit time to the renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/render_view_test.cc

Issue 979443002: PlzNavigate: send history params at commit time to the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/navigation_params.cc ('k') | content/renderer/accessibility/renderer_accessibility_browsertest.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/render_view_test.cc

diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc

index 9f49968b92321bb94fa634c49fb87dd6222cddfa..a8702109d4458abd74104646147c0e0a4c6a6d18 100644

--- a/content/public/test/render_view_test.cc

+++ b/content/public/test/render_view_test.cc

@@ -444,11 +444,13 @@ void RenderViewTest::GoToOffset(int offset, const PageState& state) {

navigate_params.common_params.navigation_type =

FrameMsg_Navigate_Type::NORMAL;

navigate_params.common_params.transition = ui::PAGE_TRANSITION_FORWARD_BACK;

- navigate_params.current_history_list_length = history_list_length;

- navigate_params.current_history_list_offset = impl->history_list_offset_;

- navigate_params.pending_history_list_offset = pending_offset;

- navigate_params.page_id = impl->page_id_ + offset;

- navigate_params.commit_params.page_state = state;

+ navigate_params.history_params.current_history_list_length =

+ history_list_length;

+ navigate_params.history_params.current_history_list_offset =

+ impl->history_list_offset_;

+ navigate_params.history_params.pending_history_list_offset = pending_offset;

+ navigate_params.history_params.page_id = impl->page_id_ + offset;

+ navigate_params.history_params.page_state = state;

navigate_params.request_time = base::Time::Now();

FrameMsg_Navigate navigate_message(impl->GetMainRenderFrame()->GetRoutingID(),