Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 979443002: PlzNavigate: send history params at commit time to the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 2227 matching lines...) Expand 10 before | Expand all | Expand 10 after
2238 // TODO(davidben): Remove this in favor of passing a cache policy to the 2238 // TODO(davidben): Remove this in favor of passing a cache policy to the
2239 // loadHistoryItem call in OnNavigate. That requires not overloading 2239 // loadHistoryItem call in OnNavigate. That requires not overloading
2240 // UseProtocolCachePolicy to mean both "normal load" and "determine cache 2240 // UseProtocolCachePolicy to mean both "normal load" and "determine cache
2241 // policy based on load type, etc". 2241 // policy based on load type, etc".
2242 internal_data->set_cache_policy_override( 2242 internal_data->set_cache_policy_override(
2243 WebURLRequest::UseProtocolCachePolicy); 2243 WebURLRequest::UseProtocolCachePolicy);
2244 } 2244 }
2245 2245
2246 if (IsReload(params.common_params.navigation_type)) 2246 if (IsReload(params.common_params.navigation_type))
2247 document_state->set_load_type(DocumentState::RELOAD); 2247 document_state->set_load_type(DocumentState::RELOAD);
2248 else if (params.commit_params.page_state.IsValid()) 2248 else if (params.history_params.page_state.IsValid())
2249 document_state->set_load_type(DocumentState::HISTORY_LOAD); 2249 document_state->set_load_type(DocumentState::HISTORY_LOAD);
2250 else 2250 else
2251 document_state->set_load_type(DocumentState::NORMAL_LOAD); 2251 document_state->set_load_type(DocumentState::NORMAL_LOAD);
2252 2252
2253 internal_data->set_is_overriding_user_agent( 2253 internal_data->set_is_overriding_user_agent(
2254 params.commit_params.is_overriding_user_agent); 2254 params.commit_params.is_overriding_user_agent);
2255 internal_data->set_must_reset_scroll_and_scale_state( 2255 internal_data->set_must_reset_scroll_and_scale_state(
2256 params.common_params.navigation_type == 2256 params.common_params.navigation_type ==
2257 FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL); 2257 FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL);
2258 document_state->set_can_load_local_resources(params.can_load_local_resources); 2258 document_state->set_can_load_local_resources(params.can_load_local_resources);
2259 } 2259 }
2260 2260
2261 NavigationState* RenderViewImpl::CreateNavigationStateFromPending() { 2261 NavigationState* RenderViewImpl::CreateNavigationStateFromPending() {
2262 const FrameMsg_Navigate_Params& params = *pending_navigation_params_.get(); 2262 const FrameMsg_Navigate_Params& params = *pending_navigation_params_.get();
2263 NavigationState* navigation_state = NULL; 2263 NavigationState* navigation_state = NULL;
2264 2264
2265 // A navigation resulting from loading a javascript URL should not be treated 2265 // A navigation resulting from loading a javascript URL should not be treated
2266 // as a browser initiated event. Instead, we want it to look as if the page 2266 // as a browser initiated event. Instead, we want it to look as if the page
2267 // initiated any load resulting from JS execution. 2267 // initiated any load resulting from JS execution.
2268 if (!params.common_params.url.SchemeIs(url::kJavaScriptScheme)) { 2268 if (!params.common_params.url.SchemeIs(url::kJavaScriptScheme)) {
2269 navigation_state = NavigationState::CreateBrowserInitiated( 2269 navigation_state = NavigationState::CreateBrowserInitiated(
2270 params.page_id, 2270 params.history_params.page_id,
2271 params.pending_history_list_offset, 2271 params.history_params.pending_history_list_offset,
2272 params.should_clear_history_list, 2272 params.history_params.should_clear_history_list,
2273 params.common_params.transition); 2273 params.common_params.transition);
2274 navigation_state->set_should_replace_current_entry( 2274 navigation_state->set_should_replace_current_entry(
2275 params.should_replace_current_entry); 2275 params.should_replace_current_entry);
2276 navigation_state->set_transferred_request_child_id( 2276 navigation_state->set_transferred_request_child_id(
2277 params.transferred_request_child_id); 2277 params.transferred_request_child_id);
2278 navigation_state->set_transferred_request_request_id( 2278 navigation_state->set_transferred_request_request_id(
2279 params.transferred_request_request_id); 2279 params.transferred_request_request_id);
2280 navigation_state->set_allow_download(params.common_params.allow_download); 2280 navigation_state->set_allow_download(params.common_params.allow_download);
2281 navigation_state->set_extra_headers(params.extra_headers); 2281 navigation_state->set_extra_headers(params.extra_headers);
2282 } else { 2282 } else {
(...skipping 1716 matching lines...) Expand 10 before | Expand all | Expand 10 after
3999 std::vector<gfx::Size> sizes; 3999 std::vector<gfx::Size> sizes;
4000 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes); 4000 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
4001 if (!url.isEmpty()) 4001 if (!url.isEmpty())
4002 urls.push_back( 4002 urls.push_back(
4003 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes)); 4003 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
4004 } 4004 }
4005 SendUpdateFaviconURL(urls); 4005 SendUpdateFaviconURL(urls);
4006 } 4006 }
4007 4007
4008 } // namespace content 4008 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698