Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 979443002: PlzNavigate: send history params at commit time to the renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 2236 matching lines...) Expand 10 before | Expand all | Expand 10 after
2247 // TODO(davidben): Remove this in favor of passing a cache policy to the 2247 // TODO(davidben): Remove this in favor of passing a cache policy to the
2248 // loadHistoryItem call in OnNavigate. That requires not overloading 2248 // loadHistoryItem call in OnNavigate. That requires not overloading
2249 // UseProtocolCachePolicy to mean both "normal load" and "determine cache 2249 // UseProtocolCachePolicy to mean both "normal load" and "determine cache
2250 // policy based on load type, etc". 2250 // policy based on load type, etc".
2251 internal_data->set_cache_policy_override( 2251 internal_data->set_cache_policy_override(
2252 WebURLRequest::UseProtocolCachePolicy); 2252 WebURLRequest::UseProtocolCachePolicy);
2253 } 2253 }
2254 2254
2255 if (IsReload(params.common_params.navigation_type)) 2255 if (IsReload(params.common_params.navigation_type))
2256 document_state->set_load_type(DocumentState::RELOAD); 2256 document_state->set_load_type(DocumentState::RELOAD);
2257 else if (params.commit_params.page_state.IsValid()) 2257 else if (params.history_params.page_state.IsValid())
2258 document_state->set_load_type(DocumentState::HISTORY_LOAD); 2258 document_state->set_load_type(DocumentState::HISTORY_LOAD);
2259 else 2259 else
2260 document_state->set_load_type(DocumentState::NORMAL_LOAD); 2260 document_state->set_load_type(DocumentState::NORMAL_LOAD);
2261 2261
2262 internal_data->set_is_overriding_user_agent( 2262 internal_data->set_is_overriding_user_agent(
2263 params.commit_params.is_overriding_user_agent); 2263 params.commit_params.is_overriding_user_agent);
2264 internal_data->set_must_reset_scroll_and_scale_state( 2264 internal_data->set_must_reset_scroll_and_scale_state(
2265 params.common_params.navigation_type == 2265 params.common_params.navigation_type ==
2266 FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL); 2266 FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL);
2267 document_state->set_can_load_local_resources(params.can_load_local_resources); 2267 document_state->set_can_load_local_resources(params.can_load_local_resources);
2268 } 2268 }
2269 2269
2270 NavigationState* RenderViewImpl::CreateNavigationStateFromPending() { 2270 NavigationState* RenderViewImpl::CreateNavigationStateFromPending() {
2271 const FrameMsg_Navigate_Params& params = *pending_navigation_params_.get(); 2271 const FrameMsg_Navigate_Params& params = *pending_navigation_params_.get();
2272 NavigationState* navigation_state = NULL; 2272 NavigationState* navigation_state = NULL;
2273 2273
2274 // A navigation resulting from loading a javascript URL should not be treated 2274 // A navigation resulting from loading a javascript URL should not be treated
2275 // as a browser initiated event. Instead, we want it to look as if the page 2275 // as a browser initiated event. Instead, we want it to look as if the page
2276 // initiated any load resulting from JS execution. 2276 // initiated any load resulting from JS execution.
2277 if (!params.common_params.url.SchemeIs(url::kJavaScriptScheme)) { 2277 if (!params.common_params.url.SchemeIs(url::kJavaScriptScheme)) {
2278 navigation_state = NavigationState::CreateBrowserInitiated( 2278 navigation_state = NavigationState::CreateBrowserInitiated(
2279 params.page_id, 2279 params.history_params.page_id,
2280 params.pending_history_list_offset, 2280 params.history_params.pending_history_list_offset,
2281 params.should_clear_history_list, 2281 params.history_params.should_clear_history_list,
2282 params.common_params.transition); 2282 params.common_params.transition);
2283 navigation_state->set_should_replace_current_entry( 2283 navigation_state->set_should_replace_current_entry(
2284 params.should_replace_current_entry); 2284 params.should_replace_current_entry);
2285 navigation_state->set_transferred_request_child_id( 2285 navigation_state->set_transferred_request_child_id(
2286 params.transferred_request_child_id); 2286 params.transferred_request_child_id);
2287 navigation_state->set_transferred_request_request_id( 2287 navigation_state->set_transferred_request_request_id(
2288 params.transferred_request_request_id); 2288 params.transferred_request_request_id);
2289 navigation_state->set_allow_download(params.common_params.allow_download); 2289 navigation_state->set_allow_download(params.common_params.allow_download);
2290 navigation_state->set_extra_headers(params.extra_headers); 2290 navigation_state->set_extra_headers(params.extra_headers);
2291 } else { 2291 } else {
(...skipping 1739 matching lines...) Expand 10 before | Expand all | Expand 10 after
4031 std::vector<gfx::Size> sizes; 4031 std::vector<gfx::Size> sizes;
4032 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes); 4032 ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
4033 if (!url.isEmpty()) 4033 if (!url.isEmpty())
4034 urls.push_back( 4034 urls.push_back(
4035 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes)); 4035 FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
4036 } 4036 }
4037 SendUpdateFaviconURL(urls); 4037 SendUpdateFaviconURL(urls);
4038 } 4038 }
4039 4039
4040 } // namespace content 4040 } // namespace content
OLDNEW
« content/renderer/render_frame_impl.cc ('K') | « content/renderer/render_view_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698