UMA: use a more frequent upload interval for Chromecast.

components/metrics/metrics_reporting_scheduler.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_METRICS_METRICS_REPORTING_SCHEDULER_H_
 #define COMPONENTS_METRICS_METRICS_REPORTING_SCHEDULER_H_
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "components/metrics/net/network_metrics_provider.h"
 
 namespace metrics {
 
 // Scheduler task to drive a MetricsService object's uploading.
 class MetricsReportingScheduler {
  public:
   // Creates MetricsServiceScheduler object with the given |upload_callback|
-  // callback to call when uploading should happen and |cellular_callback|
-  // callback to get current network connection type.
+  // callback to call when uploading should happen and
+  // |upload_interval_callback| to determine the interval between uploads
+  // in steady state.
   MetricsReportingScheduler(
       const base::Closure& upload_callback,
-      const base::Callback<void(bool*)>& cellular_callback);
+      const base::Callback<base::TimeDelta(void)>& upload_interval_callback);
   ~MetricsReportingScheduler();
 
   // Starts scheduling uploads. This in a no-op if the scheduler is already
   // running, so it is safe to call more than once.
   void Start();
 
   // Stops scheduling uploads.
   void Stop();
 
   // Callback from MetricsService when the startup init task has completed.
@@ skipping 14 matching lines @@
   // metrics.
   void TriggerUpload();
 
   // Schedules a future call to TriggerUpload if one isn't already pending.
   void ScheduleNextUpload();
 
   // Increases the upload interval each time it's called, to handle the case
   // where the server is having issues.
   void BackOffUploadInterval();
 
-  // Returns upload interval based on the system and experiment that the user is
-  // assigned to.
+  // Returns upload interval to use in steady state.
+  base::TimeDelta GetStandardUploadInterval();
+
+  // Returns upload interval specified for the current experiment running.
   // TODO(gayane): Only for experimenting with upload interval for Android
   // (bug: 17391128). Should be removed once the experiments are done.
-  base::TimeDelta GetStandardUploadInterval();
+  base::TimeDelta GetUploadIntervalFromExperiment();

[Alexei Svitkine (slow), 2015/03/09 17:26:17]

This can be removed - see my other comment.

[gunsch, 2015/03/13 00:50:12]

Done.

 
   // The MetricsService method to call when uploading should happen.
   const base::Closure upload_callback_;
 
   base::OneShotTimer<MetricsReportingScheduler> upload_timer_;
 
   // The interval between being told an upload is done and starting the next
   // upload.
   base::TimeDelta upload_interval_;
 
   // The tick count of the last time log upload has been finished and null if no
   // upload has been done yet.
   base::TimeTicks last_upload_finish_time_;
 
   // Indicates that the scheduler is running (i.e., that Start has been called
   // more recently than Stop).
   bool running_;
 
   // Indicates that the last triggered upload hasn't resolved yet.
   bool callback_pending_;
 
   // Whether the InitTaskComplete() callback has been called.
   bool init_task_complete_;
 
   // Whether the initial scheduled upload timer has fired before the init task
   // has been completed.
   bool waiting_for_init_task_complete_;
 
-  // Callback function used to get current network connection type.
-  base::Callback<void(bool*)> cellular_callback_;
+  // Callback function used to get the standard upload time.
+  base::Callback<base::TimeDelta(void)> upload_interval_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(MetricsReportingScheduler);
 };
 
 }  // namespace metrics
 
 #endif  // COMPONENTS_METRICS_METRICS_REPORTING_SCHEDULER_H_